Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if named_hexagonal_lattice_graph(n, m; periodic = true) is called with n or m = 2 #59

Open
JoeyT1994 opened this issue Apr 15, 2024 · 0 comments

Comments

@JoeyT1994
Copy link
Contributor

JoeyT1994 commented Apr 15, 2024

We should throw an error if named_hexagonal_lattice_graph(n, m; periodic = true) is called with n =2 or m = 2 because this will output a graph that essentially is a ladder (with shortest loop size 4) and resembles nothing like a hexagonal graph so may be misleading to the user.

This is likely an issue implicitly tied to the hexagonal lattice itself (hexagonal_lattice_graph for Networkx in Python also has the same output).

@mtfishman mtfishman changed the title Throw an error if hexagonal_lattice_graph(n, m; periodic = true) is called with n or m = 2 Throw an error if named_hexagonal_lattice_graph(n, m; periodic = true) is called with n or m = 2 Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant