Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Aqua test #5

Closed
wants to merge 1 commit into from
Closed

fix Aqua test #5

wants to merge 1 commit into from

Conversation

ogauthe
Copy link
Contributor

@ogauthe ogauthe commented Dec 11, 2024

This PR mimics ITensor/FusionTensors.jl#3:

  • remove test/Project.toml
  • enable Aqua test
  • not sure of this: remove sources from Project.toml. This was needed to get passing tests.

With this PR, ] test SymmetrySectors passes all test in the local project.

@ogauthe
Copy link
Contributor Author

ogauthe commented Dec 11, 2024

Hmm, looks like I missed something. @lkdvos do you have a clue?

@lkdvos
Copy link
Contributor

lkdvos commented Dec 11, 2024

I'll have a look later, but it seems like we're both doing the same thing: #3

@ogauthe
Copy link
Contributor Author

ogauthe commented Dec 11, 2024

Indeed, I wrote this PR to fix tests in #4 but #3 may already fix them. I will close this if #4 test pass once #3 is merged.

@lkdvos
Copy link
Contributor

lkdvos commented Dec 11, 2024

Sorry, I was reading this on my phone this morning and didn't really see what was going on. Indeed, the problems should be fixed with the changes in that other PR.

In case you wanted to know in more detail, the issue here is that this version of the CI test script is not yet using the centralized one we have in ITensors/ITensorActions. The main difference is that the buildpkg substep takes an (optional) argument to supply additional registries that you want it to install, which here is required for the CI to find the LabelledNumbers.jl package. The relevant line is:
https://github.com/ogauthe/SymmetrySectors.jl/blob/b501810d74bcb1646763fe55b63f5ab67120fab8/.github/workflows/CI.yml#L41
compared to
https://github.com/ITensor/ITensorActions/blob/617bb0004c5a4704e6db4f6372e07f37a79f57d8/.github/workflows/Tests.yml#L103-L106

@ogauthe
Copy link
Contributor Author

ogauthe commented Dec 11, 2024

No more needed thanks to #3

@ogauthe ogauthe closed this Dec 11, 2024
@ogauthe ogauthe deleted the Aqua branch December 17, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants