Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the issues in the tests #7

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

kmp5VT
Copy link
Contributor

@kmp5VT kmp5VT commented Dec 2, 2024

Description

This PR seeks to fix the issues pointed out by Matt in the initial commit of this repo.

Fixes #(issue)

I added a extensions for FillArrays and created default type parameters for an AbstractFill.

Checklist:

  • Default parameters are defined for AbstractFill and AbstractUnallocatedFill types.
  • Tests all run as expected with no errors

@kmp5VT kmp5VT changed the title Fixing the issues in the tests and adding default types for FillArrays in an extension. Fixing the issues in the tests Dec 2, 2024
@kmp5VT
Copy link
Contributor Author

kmp5VT commented Dec 2, 2024

@mtfishman It looks like the problem was related to looping over the types written as sybmols. For example in for typ in (:Fill, :Zeros), typ was being interpreted as a symbol and, though we had defined a default_type_parameter for the AbstractFill type, we don't have default parameters defined for symbols which was causing the code to error out.

test/test_defaults.jl Outdated Show resolved Hide resolved
@mtfishman
Copy link
Member

Can you delete the corresponding commented code from test_basics.jl?

@lkdvos
Copy link
Contributor

lkdvos commented Dec 10, 2024

@mtfishman , I think the easiest would be if you merge this, I'll apply the new skeleton on top of that in a separate PR?

@mtfishman mtfishman merged commit 6f2ed71 into ITensor:main Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants