Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with the borders on the skills section on homepage #47

Closed
nilis24 opened this issue Oct 22, 2023 · 6 comments
Closed

Problem with the borders on the skills section on homepage #47

nilis24 opened this issue Oct 22, 2023 · 6 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@nilis24
Copy link

nilis24 commented Oct 22, 2023

Hi! It's the first time I visited this repository and I visited the website. I detected that there is a problem with the borders on the skills sections on the homepage, and it is that the borders are not well placed, there are places where they are missing or there are places where there are too many, that is to say, there is no logical order in this. I attach a picture to show what I mean:

image

I can solve this issue, so please assign it to me 🙏

@Iamdivyak
Copy link
Owner

assigned @nilis24

@nilis24
Copy link
Author

nilis24 commented Oct 22, 2023

Thank you!! 🤩🤩

@nilis24
Copy link
Author

nilis24 commented Oct 23, 2023

Do you like it like this? I thought you only wanted to put the inside borders but it is difficult to make this design responsive. So I came up with this to solve it, what do you think?
image

@Iamdivyak
Copy link
Owner

this design is too easy. not so interesting, come up with another alternatives

@Iamdivyak
Copy link
Owner

https://www.figma.com/file/wKcuUSuG9uEbaXL4TytRzG/my-profile%2Fportfolio-design?type=design&node-id=1383%3A2&mode=design&t=1XdljjDrM0iKJm3A-1

I HAVE MADE ANOTHER COPY OF THE DESIGN AND MADE SOME CHANGES THERE. YOU CAN USE THAT IN YOUR STYLES

@Iamdivyak Iamdivyak added the good first issue Good for newcomers label Oct 28, 2023
@Iamdivyak
Copy link
Owner

Iamdivyak commented Oct 29, 2023

pr #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants