fix: fix get install info not ready cause panic

IceWhaleTech · May 17, 2024 · 04bcc19 · 04bcc19
1 parent 4e5f473
commit 04bcc19
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/route/installer.go b/route/installer.go
@@ -164,10 +164,16 @@ func (a *api) GetInstall(ctx echo.Context) error {
 		})
 	}
 
+	if release == nil {
+		return ctx.JSON(http.StatusInternalServerError, &codegen.ResponseInternalServerError{
+			Message: lo.ToPtr("release is not ready"),
+		})
+	}
+
 	path, err := service.InstallerService.InstallInfo(*release, config.SysRoot)
 	if err != nil {
 		return ctx.JSON(http.StatusInternalServerError, &codegen.ResponseInternalServerError{
-			Message: utils.Ptr(err.Error()),
+			Message: lo.ToPtr(err.Error()),
 		})
 	}
 	return ctx.JSON(http.StatusOK, &codegen.InstallInfoOk{

diff --git a/service/status_serivce.go b/service/status_serivce.go
@@ -162,6 +162,7 @@ func (r *StatusService) Install(release codegen.Release, sysRoot string) error {
 }
 
 func (r *StatusService) GetRelease(ctx context.Context, tag string) (*codegen.Release, error) {
+	// TODO: cache release in disk
 	return r.release, nil
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     }
     func (r *StatusService) GetRelease(ctx context.Context, tag string) (*codegen.Release, error) {
+    	// TODO: cache release in disk
     	return r.release, nil
     }
@@ Expand Down @@