-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy&Paste of container element with children #74
Comments
Hi @z-gingco, Thank you for submitting the issue. Unfortunately I'm unable to reproduce your issue. Maybe this is related to the flux extension you are using. If you have further information, please submit a pull request. Maybe the flux extension needs some adjustments to be compatible to content_defender and needs to use one or more signals provided by the extension. |
I have a similar error, using b13/container, when setting "allowed" in a container to a certain other container element which has children. The error message "couldn't be saved due to disallowed value(s)" fires for every content element inside the allowed container element, when i.e. moving this element to the outer container element. After reloading the backend, everything is, as it should be, but the error message is wrong here, because I am moving an allowed container element, so the children should not throw this error. Do you think this could also a problem with b13/container and I should report the error there? |
Hi @rafu1987, Thank you for your report. I found this ticket in the container repository b13/container#84 dealing with copy & paste of container elements. Can you check if you are using the most current version of both extensions and maybe raise a new ticket in the container repository with all needed information to be able to reproduce the problem? |
Hi @IchHabRecht, I think the error was due to different container elements, having same colPos values. I gave every container a unique colPos and the error is now gone, so I think that was it for me. Thanks for the feedback and your great work on content_defender! :-) |
Hi @z-gingco, I comparison to the EXT:container extension, I guess the inline elements of your flux container elements are using any colPos defined in the backend_layout with some content_defender restrictions set?! So the flux extension needs to provide a valid (or none) configuration for inline elements to content_defender to be able to correctly copy & paste them. |
There was a bugfix in b13/container, which helps to reduce this issue b13/container/#112 |
Hello @IchHabRecht, first of all thanks a lot for looking into this issue. We have investigated further and noticed that in our setup, the functionality has been broken since the update of Flux from 9.3.2 to 9.4. After rolling back the following commit - FluidTYPO3/flux@42d16f0 - everything works. Do you have any idea why this would break things? Should I give you an example of our flux form? Thanks again |
Hi @z-gingco, Thank you for providing further information. Unfortunately I do not use the EXT:flux by myself, so I'm not able to give any kind of support. Maybe the extension developer can give further information about the compatibility between both extension or is able to provide proper fixes for a new release. |
@IchHabRecht thanks for your answer, I opened an issue in the flux repo FluidTYPO3/flux#1876. |
@IchHabRecht, having the same (?) situation for container elements created with mask/mask_export. On top I use my own EXT:dragon_drop to be able to move CEs within, to and from colPos 999. Scenario:
✔️ Moving a textmedia CE from colPos 0 to colPos 999 works fine. Probably I'd have to hook into content_defender to make its |
Hi all, This issue should be fixed with #117 as IRRE content elements are now ignored from content_defender processing. |
Our template has a number of container elements built with flux. The container elements are allowed inside the backend layout columns (e.g CType = xyz_sectioncontainer,xyz_teasercontainer) whereas basic elements like text, textpic, etc. are not allowed to be inserted directly into the content column. It works perfectly, except for the case when an editor tries to copy/paste a container to a new location. In this case only the container itself gets copied and for each of the children elements an error message "record couldn't be saved due to disallowed value(s)" appears.
![image](https://user-images.githubusercontent.com/74311347/98829904-0aa1a180-243a-11eb-80a1-34de9786d42a.png)
An interesting observation - when the copied container is inserted before the original container, all works well; when after the original container the errors described above occur.
Thanks for looking into this and for your great work!
The text was updated successfully, but these errors were encountered: