Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instructions for Distrobox #22

Closed
danyeaw opened this issue May 27, 2024 · 6 comments
Closed

Add Instructions for Distrobox #22

danyeaw opened this issue May 27, 2024 · 6 comments

Comments

@danyeaw
Copy link

danyeaw commented May 27, 2024

Hi, thanks for the SDK, this definitely makes setting up a development environment much easier!

As a distrobox user, I did something like:

distrobox create --image ghcr.io/wkdev:latest wkdev
distrobox enter wkdev
git clone https://github.com/WebKit/WebKit.git WebKit
cd WebKit
Tools/Scripts/build-webkit --gtk

Would you be open to adding distrobox instructions?

@TingPing
Copy link
Member

While the image alone is very useful, we also have some custom scripts that are expected to be ran.

Maybe we could document that, someone will need to test and write it all down.

@nikolaszimmermann
Copy link
Member

What came to your mind @TingPing?
@danyeaw - did you have any issues building + using WebKit this way?

@nikolaszimmermann
Copy link
Member

@danyeaw ping :-)

@danyeaw
Copy link
Author

danyeaw commented Nov 21, 2024

Hi @nikolaszimmermann, with the steps above things worked great.

@TingPing
Copy link
Member

What I meant is we have a list of custom permissions:

build_podman_create_arguments() {

And we have an init script:

https://github.com/Igalia/webkit-container-sdk/blob/main/scripts/container-only/.wkdev-init

Distrobox itself handles some of the things we do but not necessarily all. So running WebKit may behave differently.

@danyeaw
Copy link
Author

danyeaw commented Nov 25, 2024

Hi @TingPing, thanks! I think we can go ahead and close this one then.

@danyeaw danyeaw closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants