Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkg-config and version information to every jhbuild module #60

Open
dpino opened this issue Oct 4, 2024 · 2 comments
Open

Add pkg-config and version information to every jhbuild module #60

dpino opened this issue Oct 4, 2024 · 2 comments

Comments

@dpino
Copy link
Member

dpino commented Oct 4, 2024

Moved from #51 (comment)

When pkg-config and version information are present in a jhbuild module, jhbuild will compare the version requested to the version of the library installed via system packages (in case the package was installed). If the system package is newer, then the module is skipped.

Avoiding building modules that are already installed as system libraries will reduce the size of the image. Having pkg-info and version present will also help to inadvertely downgrade a package that is already installed (In case you need to downgrade a package, simply remove the pkg-config or version from the module configuration).

In any case, it seems this mechanism only works in jhbuild for tarballs. I have pushed a merge-request to make the same logic work with git branches:

We have many modules setup as git branches, so we need to get that merge-request merged and jhbuild updated before implementing this change cc @TingPing

@TingPing
Copy link
Member

FWIW I don't really see the point of this. We control the versions in the SDK, sans micro version updates by Ubuntu. So we just remove any modules we don't need whenever.

@dpino
Copy link
Member Author

dpino commented Nov 4, 2024

FWIW I don't really see the point of this. We control the versions in the SDK, sans micro version updates by Ubuntu. So we just remove any modules we don't need whenever.

The meson module was part of the JHBuild moduleset for a long time even though it was not necessary (#37). The same is currently happening with the openh264 module, as I explained in #51 (comment).

IMHO, the best way to inadvertely downgrading a module via JHBuild, or installing a module that it's not necessary, is to attach the pkg-config information to every module (whenever possible). It may also help to save time in the build of the JHBuild modules and save space in the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants