Update the WebContent instance when setting an UA override #94
This pull request is big! We’re only showing the most recent 250 commits.
Commits on Oct 27, 2023
Commits on Oct 28, 2023
-
[skylab_tests] Update skylab cros img (release)
This cl only affect Lacros or Skylab on-device config builders like lacros-amd64-generic-chrome-skylab or "ChromeOS FYI Release Skylab (kevin)". This cl will certainly NOT affect linux-lacros builders (linux-lacros-tester-rel, linux-lacros-rel, etc) or any other platforms. This CL will update cros image version for skylab tests. CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Requires-Testing: True Change-Id: I7a869dacf18024ba7e7cc4a220912ede7a7739b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4986482 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1464} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Commits on Oct 29, 2023
Commits on Oct 30, 2023
Commits on Oct 31, 2023
-
Gardener: Disable flaky Metrics test on ChromeOS
MetricsServiceBrowserSampledOutTest.FilesRemoved was disabled on Mac several months ago, but it's also flaky on ChromeOS: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel (cherry picked from commit 40b0ce9) Bug: 1380375, 1378228 Change-Id: I67b5efaf0d2bffc49b7f438ce521b0c7e9bb187c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4875117 Auto-Submit: Austin Sullivan <[email protected]> Reviewed-by: Fabio Tirelo <[email protected]> Commit-Queue: Fabio Tirelo <[email protected]> Owners-Override: Fabio Tirelo <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1198021} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4995808 Auto-Submit: Joseph Park <[email protected]> Owners-Override: Joseph Park <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1506} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Commits on Nov 1, 2023
-
[M118] Retry notarization failures in the internal invoker
This cherry-picks the following commits: eb9f3eb Roll src/chrome/installer/mac/internal/ 3cb1c9bad..ed0d43308 (2 commits) e06e58c macOS Signing Scripts: Make the retry logic part of the notarize module API 1bf5c0c macOS Signing Scripts: Remove legacy notarization arguments e096178 Roll src/chrome/installer/mac/internal/ d7fb448e1..3cb1c9bad (1 commit) Bug: 1496421, b/281728988, 1442256 Change-Id: If0e4d435b2f3aaf1cd6d0064081c5dbc750d47b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4974536 Auto-Submit: Robert Sesek <[email protected]> Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1509} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Commits on Nov 2, 2023
Commits on Nov 3, 2023
-
Check context status before recreating platform destination
Changing the channel count in the RealtimeAudioDestinationHandler will trigger the recreation of the platform destination. This in turn can activate the audio rendering thread. This CL adds a check to prevent this from happening after the handler is garbage collected. (cherry picked from commit 4997f2b) Bug: 1497859 Test: Locally confirmed with ASAN Change-Id: I5d2649f3fd3639779ae40b0ca4ef2fe305653421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4995928 Commit-Queue: Hongchan Choi <[email protected]> Reviewed-by: Michael Wilson <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1217868} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5004961 Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1520} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Commits on Nov 4, 2023
Commits on Nov 5, 2023
Commits on Nov 6, 2023
-
[skylab_tests] Update skylab cros img (release)
This cl only affect Lacros or Skylab on-device config builders like lacros-amd64-generic-chrome-skylab or "ChromeOS FYI Release Skylab (kevin)". This cl will certainly NOT affect linux-lacros builders (linux-lacros-tester-rel, linux-lacros-rel, etc) or any other platforms. This CL will update cros image version for skylab tests. CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Requires-Testing: True Change-Id: I837c1792665685f80eff77694e587b9cad6d8954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002767 Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1531} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Commits on Nov 7, 2023
Commits on Nov 8, 2023
-
[Merge to M118] Make URLSearchParams persistent to avoid UaF
The URLSearchParams::Create() function returns an on-heap object, but it can be garbage collected, so making it a persistent variable in DidFetchDataLoadedString() mitigates the issue. (cherry picked from commit 8b1bd77) Bug: 1497997 Change-Id: I4ae0f93fccc561cd8a088d3fa0bf2968bf298acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4996929 Reviewed-by: Adam Rice <[email protected]> Commit-Queue: Nidhi Jaju <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1218682} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5007484 Commit-Queue: Adam Rice <[email protected]> Auto-Submit: Nidhi Jaju <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1546} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
-
[lacros] Update lacros QA qualified version
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This file will be used in Upreving the RootFS-Lacros in the CROS image. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Change-Id: I415c776e45fb8e21ea22b517b8d56a1659a0a640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5014326 Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1554} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Commits on Nov 9, 2023
-
[skylab_tests] Update skylab cros img (release)
This cl only affect Lacros or Skylab on-device config builders like lacros-amd64-generic-chrome-skylab or "ChromeOS FYI Release Skylab (kevin)". This cl will certainly NOT affect linux-lacros builders (linux-lacros-tester-rel, linux-lacros-rel, etc) or any other platforms. This CL will update cros image version for skylab tests. CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Requires-Testing: True Change-Id: Id1349380eba9e39ce8dcdace650281d21d800317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5015364 Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1558} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Commits on Nov 10, 2023
-
[skylab_tests] Update skylab cros img (release)
This cl only affect Lacros or Skylab on-device config builders like lacros-amd64-generic-chrome-skylab or "ChromeOS FYI Release Skylab (kevin)". This cl will certainly NOT affect linux-lacros builders (linux-lacros-tester-rel, linux-lacros-rel, etc) or any other platforms. This CL will update cros image version for skylab tests. CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Requires-Testing: True Change-Id: I72a76e30a22dfe8db0bb7a4d6c58a1c175e8df71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5017781 Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1568} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
-
[M118] Use WeakPointer for the loader fallback callback.
`MaybeStartLoader` binds an unretained pointer to `FallbackToNonInterceptedRequest`, which is passed through a series of objects until it reaches `ServiceWorkerMainResourceLoader`. When "network" or "cache" is selected as a ServiceWorker static routing API's source and caused the network fallback, the unretained pointer can be released and may cause use-after-free. This CL changes the unretained pointer to a weak pointer to avoid that. For the consistency of the function call, both of the callbacks starts to use weak pointers. (cherry picked from commit 83d6374) Bug: 1499298 Change-Id: I7e7c93fa389ab35584703f30bfc722eadeca81dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5004329 Reviewed-by: Shunya Shishido <[email protected]> Reviewed-by: Minoru Chikamune <[email protected]> Reviewed-by: Takashi Toyoshima <[email protected]> Commit-Queue: Yoshisato Yanagisawa <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1220697} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5019877 Cr-Commit-Position: refs/branch-heads/5993@{#1570} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
-
[M118] [HFM] Don't bind WebContents pointer in HSTS query callback
Because the call to NetworkContext::IsHSTSActiveForHost() is async, it is possible for the WebContents to be destroyed before the callback to MaybeCreateLoaderOnHstsQueryCompleted() is run. This changes the callback to get the WebContents using `frame_tree_node_id_` again and verify that it is still valid when the callback is run, and similarly reconstruct the Profile and TabHelper rather than needing to bind them into the callback. (cherry picked from commit 4208e44) Fixed: 1499515 Change-Id: I52ffefc5586771d21f4860eefca09b933b87ec6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5014874 Reviewed-by: Mustafa Emre Acer <[email protected]> Commit-Queue: Chris Thompson <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1221998} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5021209 Auto-Submit: Chris Thompson <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1577} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Commits on Nov 11, 2023
Commits on Nov 12, 2023
Commits on Nov 13, 2023
-
Initial implementation for wolvic (experimental)
- parent : #505125 (JDK11/v8 11.0.211)
-
Add WolvicContentClient and UA methods (#2)
This CL adds WolvicContentClient class and methods of the user agent in WolvicContentBrowserClient. Co-authored-by: Miyoung Shin <[email protected]>
-
This CL solves the java error message, 'java.lang.NoSuchMethodError: No virtual method position(I)Ljava/nio/ByteBuffer; in class Ljava/nio/ByteBuffer;'. In Java 8 used by Wolvic, the class ByteBuffer inherits the position method from the class Buffer and has a return type of java.nio.Buffer. On Java 11 and lather used by chromium, the method is overridden with an implementation that returns java.nio.ByteBuffer. So, this changes to do explicitly the downcast from the class ByteBuffer to the class Buffer for the backward compatibility according to the Java version.
-
-
Add jni codes to create WebContents for wolvic (#5)
This PR add jni codes to create WebContents for wolvic with the newly created java class `Tab`.
-
Support fullscreen & media control
This CL exposes fullscreen and media APIs to Java layer to support fullcreen and media control. - Add setWebContentsDelegate in tab jni to enter/exit fullcreen - Expose scrubTo(=fast seek)/setMute to Java layer - Add a |isActive| parameter to determind the media start/stop status - Add //components/browser_ui/media/* in gn to handle the artwork's images
-
Get rid of the default page loading since it's now handled by the wolvic browser.
-
Add UrlFormatter dependency to be used on Java side to have Url formatting and validation logic consistent with Chromium.
-
Migrate chromium implementations for wolvic under org.chromium.wolvic
Chromium implementations in wolvic side are migrated under org.chromium.wolvic under org.chromium.wolvic.
-
-
-
-
Fix no frame issue when reaching a maximum value of frame ID (#12)
* Fixed the white flashing issue and improved the fps - Fixed the white flashing issue When sharing textures, the following order should be ensured. Processing (write texture) in the browser -> The frame-available callback in the browser -> consuming (read texture) in Wolvic StartFrame(call UpdateTexImage) -> Draw -> EndFrame (Call ReleaseTexImage) Wolvic accesses the last texture every tick(=vsync) even if we don't set the next frame id. Then, it can cause to update/release of texture in Wolvic when the browser is processing the texture on another thread, which can be broken the above sequence. This will cause the empty buffer frame in texture and occur a white flashing issue. Reset the texture name as zero after finishing the frame to avoid the racing between processing the texture in chromium and consuming it in Wolvic. - Fixed no frame issue when reaching a maximum value of frame ID Chromium has a maximum value of frame ID as 255(uint8), and when recycling frame id to zero, processing the frame gets stuck. - Reduced the time out value to 10ms If the texture conflicts, the callback could not be called in time. We reduce the timer's time so that the next frame is handled shortly. * Update wvr_manager.cc Expand timeout as 1s to wait for the heavy GL commands * Exit the immersive VR (#13) * Exit the immesive VR Force exit WebXR before pushing the frame if the presenting generation is changed by stopping presenting in Wolvic. Co-authored-by: Miyoung Shin <[email protected]> -
* Add SelectPopup#Factory Co-authored-by: Miyoung Shin <[email protected]>
-
Fix position translation to gfx::Transform
The code was (likely due to a copy-paste error) copying the first coordinate (pose->position[0]) to all x, y, z values for the position.
-
Returns browser context based on content::BrowserContext
In WolvicContentBrowserClient, this changes the return type of the single browser context for Wolvic. Instead of returning WolvicBrowserContext, now it will return content::BrowserContext. This more coherent to other content implementations within Chromium tree (e.g. App Shell) and will be handy when initializing content::ShellDevToolsManagerDelegate in the following commit.
-
Add Chromium basic DevTools support to Wolvic
This implements CreateDevToolsManagerDelegate content method by creating a ShellDevToolsManagerDelegate object. ShellDevToolsManagerDelegate brings in a fairly large amount of Content related dependencies and (maybe we'd need to think soon whether it's time to pull in `content_shell_lib` directly instead). I've tested by connecting my Android device (Samsung S21), launching Wolvic Chromium (using noapi variant) via Android Studio and then opening chrome://inspect in the host machine. I'm able to see Wolvic in the Remote Target list and connect into. I can't interact much with the DevTools' functionalities due the fact that the noapi variant doesn't render content. Therefore further testing is necessary to check the correctness of the solution.
-
-
Implement User Agent settings (#19)
Add a mechanism of sending Wolvic settings to the Chromium backend and also implements support for the User Agent settings. Logic for the User Agent support is using the same approach as the gecko backend (SessionImpl.java). Additionally, remove GetUserAgentBasedOnPolicy() method since we're not planning to support any enterprise policies and our implementation of GetUserAgent() will be used by default.
-
Chromium: Implement basic WebXR input support (#17)
This change implements basic WebXR input support, including controller position, orientation and pressed buttons. --------- Co-authored-by: Sergio Villar Senin <[email protected]>
-
Add a method to retrieve the default user agent
Add a method to SessionSettings that returns the chromium's default user agent.
-
Revert "Add a method to retrieve the default user agent"
This reverts commit 057d20f.
-
Add SessionSettings::GetDefaultUserAgent()
Added a new method that retrieves the UA to be used by Chromium for a given mode (mobile, desktop or VR). Part of the existing code has to be moved from the content browser client to session settings in order to allow both Wolvic and the WolvicContentBrowserClient to access it.
-
wolvic: Add WvrGraphicsDelegate class
At the moment this is void but ot will serve to organize the graphics related code within WvrManager next.
-
wolvic: Change webvr WvrManager member to not be allocated dinamically
There are no funcional changes in this commit. It only serves to pave the way mostly to resemble our implementation to the GVR and ARCore ones (which we'll be referring our implementation a lot on them).
-
wolvic: Move WvrManager graphics routines to WvrGraphicsDelegate
This moves InitializeGl, CreateOrResizeWebXrSurface and other graphics specific routines to WvrGraphicsDelegate. There are no funcional changes in this commit.
-
wolvic: Change method names and add comments
This changes some method names, adds comments and a few logging information to WvrManager implementation. There are no funcional changes in this commit. It only serves to pave the way mostly to resemble our implementation to the GVR and ARCore ones (which we'll be referring our implementation a lot on them).
-
wolvic: Minor updates based on review
Swap the order of wvr_manager_ and wvr_graphics_ to ensure that wvr_manager_ is destructed before wvr_graphics_. Otherwise, there's a moment where wvr_manager_ holds an invalid raw_ptr to wvr_graphics_. Unset default WvrGraphicsDelegate values that already 0, 0.
-
Update wolvic code to run correctly after M114 update
This change introduces several small changes to fix various build and runtime errors that are happening after the M114 update.
-
Initialize the UserLevelMemoryPressureSignalGenerator
In this change we copy the chrome code for user level memory pressure signals initialization (adding the corresponding command line flag). Without this, WebXR experiences crash on Oculus Quest 2 devices.
-
wolvic: Add WvrApi class for Wolvic state handling
This adds a new class for wrapping all the procedures that involves Wolvic state sync handling. At this moment, I'm mostly interested in splitting away that from WvrManager. We may want to rename this class and its method names eventually to something more suggestive.
-
wolvic: Reorganize the frame transport choosing code
This reorganizes the code to choose the frame transport to be used in Wolvic on its own method GetWebXrFrameTransportOptions.
-
Update DEPS to use wolvic-angle repo
Update DEPS to use wolvic_experimental branch of wolvic-angle instead of chromium's angle. This fixes the performance drops caused by https://crrev.com/c/4300729.
-
Add thumbstick support to controllers
Map data coming from axis to device::Gamepad axes. The code defines a deadZone under which the thumbstick value is considered 0 as done in other parts of the code. Apart from that we're adding a couple of DCHECKs for the amount of buttons and axis coming from Wolvic. They replace an if condition as it should never really happen.
-
-
Add app=desktop param to all youtube.com requests
Add a YoutubeURLLoaderRequestInterceptor class which implements logic of ensuring that all youtube requests have the "app=desktop" parameter present. This allows Wolvic browser to play 360 youtube videos correctly.
-
wolvic: Add pending frames checkings
Add a queue for checking the exact number of produced and processed frames.
-
wolvic: Add frame bounds validation and size checking
It does also a small adjustment to create Java WVRSurfaceTexture only when the SurfaceTexture is also need to be created.
-
wolvic: Break down processing frame code in separated methods
This breaks down the processing frame state in a new method, DrawFrameSubmitNow. This also makes sure (by DCHECKing) that when OnWebXrFrameAvailable runs, the frame arriving is still in the processing state and guaranteeing the correct order functioning as defined by WebXrPresentationState. Besides, it removes an unused member of the main class (last_frame_index_).
-
Intercept any files that download manager is trying to download and forward them to be handled on the Wolvic side instead.
-
Revamp input source management
The input source management was not correct. There were some bugs in the current implementation and there are also some missing very important features. This PR implements the following: * Use the XrStandardGamepadBuilder to create the Gamepad object. This ensures that is created with the xr-standard mapping required by the WebXR implementation. Also it simplifies a bit the code. * Properly fill in the primary_input_* and primary_squeeze_* data. Those 4 values are defined in the WebXR spec (primary action and primary squeeze action) and are used to properly trigger the select* and squeeze* events. This requires storing the previous state of the controllers. * Fix touchpad and thumbstick support. There was no touchpad support at all. Also axes values were not properly filled in. Last but not least, thumbstick's click/touch/value were not filled in. Note: the index for where the data for a particular button is located follows the xr-standard gamepad mapping that can be found https://www.w3.org/TR/webxr-gamepads-module-1/#xr-standard-gamepad-mapping
-
Fix build errors caused by newly introduced DCHECKS
Add UL suffix to literals in DCHECKS to avoid build errors caused by signed vs unsigned comparison.
-
This adds GetSuggestedFrameSize method to WvrManager, which fetches the underneath system suggested frame size. This also sets WvrGraphicsDelegate to initialize GL by using the newly added method and therefore fixes the texture size being used. In practice, a visual flashing artifact we were seeing (happening between the first frames and the next ones) is gone now.
-
wolvic: Always sync system state at animating frame time
GetFrameData calls WebXrTryStartAnimatingFrame, which requires the system state to be synched properly. This CL moves SubmitFrameInternal within the WebXrTryStartAnimatingFrame, in order to get up to date system state every time the views need to be recomputed.
-
wolvic: Get rid of the time out task
Time out was a workaround that we happily can get rid of now after fixing the frame scheduling logic.
-
The transforms for each eye built from the head pose were not correct. The generated IPD was too large and there was also some abnormal rotation between both eyes. We were creating the transform matrix in row major instead of column major order. Also there was an extra matrix inversion.
-
wolvic: Lazy evaluate texture size for views
Move WvrManager::GetSuggestedFrameSize call to later at CreateViews, and get rid of screen_size attribute in the WvrGraphicsDelegate. There are no functional changes in this commit.
-
Add support for off-the-record (incognito) mode
This commit adds a new browser context to WolvicMainParts that could be used for off-the-record browsing. Tabs got a new parametter on creation that specifies whether or not to use an off-the-record browsing context.
-
Update wolvic code to run correctly after M116 update
This change introduces several small changes to fix various build and runtime errors that are happening after the M116 update.
-
Revert "Add PartialLowEndModeOnMidRangeDevices to fieldtiral_testing_…
…config.json." This reverts commit 629c681.
-
-
This commit enables disk cache directory for the current user profile. To verify the correctness one can check that the index files are being created e.g.: $ adb shell run-as com.igalia.wolvic find -type f | grep Cache ./app_content_shell/content_shell/Cache/Cache_Data/* This was tested with Oculus Quest 2 (Oculus API) and S21 (No API) devices. Worth mentioning that Content Shell, in the upstream, could benefit from a very similar change in content/shell/browser/shell_content_browser_client.cc.
-
gpu: Increase texture size limit (#41)
In the context of VR experiences, textures are over 4k and such limitation was a problem. Therefore, this commit increases the max texture size to 16384. In practice, the gpu driver bug list set this limit on Android and Linux only.
-
Wolvic: Fix time delta value in XR frame data (#45)
Time delta was being computed only once, during WebXR session initialization, resulting in fixed timestamps being forwarded to the apps. This would break those VR experiences using timestamp during rAF. In order to fix that, this changes the WebXrTryStartAnimatingFrame to compute time delta every time this method runs.
-
Add support for WebXR Hand Input Module - Level 1 (#44)
Since the support is already present in blink, we just need to fetch the hand-tracking data pushed to as part of system state updates, and populate it in the corresponding mojom data structures. We also need to advertise the `generic-hand-select` profile in the input source description, as required by the spec.
-
Initial implementation for PermissionManager
Implement initial code for managing permissions. This commit doesn't have any functional changes since every permission is automatically denied. This matches the default behavior (when PermissionControllerDelegate is set to nullptr). It's a precursor for the DRM support.
-
This change adds user_pref_service to browser_context and allows storing user preferences in the application folder. Currently, we store all user preferences in "Default/Preferences" which should be changed to use a per-profile folder in the future. It's a precursor for the DRM support.
-
This change implements DRM support (for widevine and clearkey DRMs) using the same logic as the android_webview. We don't download or store any proprietary blobs, instead we use the Android DRM framework. We also automatically grant the PROTECTED_MEDIA_IDENTIFIER permission here, which should be changed to use the permission request dialog in the future.
-
Add VisitedLinkReader and VisitedLinkWriter
These two components are used to exchange information about visited links between the browser and the renderer. The writer is the one that receives the list of visited URLs and stores them (actually a hash of the URL) in a hash table for rapid searches. The reader on the other hand, will check whether a given link found in a web page was ever visited to show it later in a different colour. Adding them is not enough to get the visited links functionality working though. We still need 2 components: * a WebContents observer tracking the visited links * a class that exposes the VisitedLinkReader interface to the browser
-
Adding WolvicContents to track visited URLs
This new class is basically a WebContentsObserver used to capture the list of visited URLs and pass them to WolvicBrowserContext so that they could be stored as visited. This object is owned by an utility class called WolvicContentsUserData that is stored as user data inside the WebContents object so that we could easily access it. As it is not passed to Java the ownership is kept in that user data class.
-
Move WolvicContentRendererClient to wolvic/renderer
This is consistent with the rest of the content renderer clients found in the Chromium sources.
-
Expose VisitLinkReader interface to the browser process
This allows the renderer and the browser to exchange data between the writer and the renderer. This bind is done in its own class which is consistent with what the rest of the Chromium code does. This is the last piece of the puzzle that allows the chromium port to properly display the visited links in a different colour.
Commits on Nov 23, 2023
-
Replace annotation_processor_deps with srcjar_deps
To follow the refactoring done here: https://crrev.com/c/4617012
-
Remove UserLevelMemoryPressureSignalGenerator
to follow the refactoring done here https://crrev.com/c/4821106
-
Fix method signatures in WolvicPermissionManager
Fix method signatures that changed after the M118 update.
-
Fix network_context_params and mailbox_bridge args
Fix usage of network_context_params and mailbox_bridge after M118 update.
-
-
Remove YoutubeUrlLoaderRequestInterceptor
Remove the Youtube redirection functionality because it will be implemented on the wolvic side.
-
Remove user data from WolvicContents on destruction
We use it to store a UserData object that keeps a reference to the WolvicContents object. That UserData is stored in WebContents object and should be removed from there once WolvicContens is destroyed.
-
Store WebContents in WolvicContents
The current code does not keep a reference to WebContents on the native side. It's using the same structure as WebContentsFactory's CreateWebContents(), but the difference is that we don't end up calling TabAndroid::InitWebContents, and thus the WebContents instance is not properly stored in a unique_ptr. Use the recently added WolvicContents object to keep track of it.
-
Store the WebContentsDelegate in WolvicContents
The current code keeps the delegate instance in an static unique_ptr in tab_jni.cc. That's unfortunate as it will be shared by all the WebContent instances and might be the source of weird behaviours. Instead it's better to use the recently added WolvicContents object to keep the unique reference to the delegate.
-
Notify clients when the web engine wants to create a new Window
Certain navigations (like target=_blank links) require the web engine to create a new Window. In those cases Chromium creates a new WebContents object and notifies the client (Wolvic in this case) about that. However the current architecture of Wolvic does not allow us to properly use that new WebContents object to create a new tab. To circumvent that, we can use the fact that Chromium cancels the creation of a new window if the ownership of the WebContents object is not taken when AddNewContents() is called on the delegate. We precisely do that (we let the new WebContents die) but we use the target_url (the URL of the new window) to notify the client (Wolvic) via a new method called onCreateNewWindow() that was added to a new object called WolvicWebContentsDelegate which directly inherits from WebContentsDelegateAndroid (the one we were using previously). The client just needs to override that onCreateWindow() method and trigger the creation of a new window there using the passed in URL.
Commits on Nov 24, 2023
-
Implement basic permissions support (#51)
* Implement basic permissions support Forward permission requests to Wolvic to show the permission request user dialog. This change only supports several basic permissions, support for more advanced things like media permissions will be added later.
-
Fix crash when navigating in incognito mode
The crash is happening in debug mode and is caused by hitting NOTREACHED: https://source.chromium.org/chromium/chromium/src/+/main:components/visitedlink/browser/visitedlink_writer.cc;l=324;drc=5eb14ef3da3c6dbcb0aa38372ad1cfafb85512c8 since Chromium doesn't allow saving visited links in incognito mode.
Commits on Dec 5, 2023
-
Add an extra null check in LoadingStateChanged
This fixes a crash that we started to observe in Quest3 devices after upgrading to M118. This null check is present in almost all the WebContentsDelegateAndroid methods but not in the LoadingStateChanged. Perhaps it's a precondition of the call and we're hitting a bug in some untested code path.
Commits on Dec 12, 2023
-
Implement JavaScript dialogs (#56)
Introduce UserDialogManagerBridge which is a bridge allowing to create wolvic user dialogs from Chromium. Use this bridge to support JavaScript dialogs such as alert, confirm, prompt and beforeunload.
Commits on Dec 20, 2023
-
Add Meta Quest3 WebXR input profile
We need to map the device type coming from Wolvic to a list of supported WebXR input profiles. This way WebXR experiences can properly render the 3D model of the actual controllers.
Commits on Jan 24, 2024
-
Handle SecurityException when calling getCameraCharacteristics
Backported from upstream. Fixes #63 --- Handle SecurityException when calling getCameraCharacteristics Under some circumstances SecurityException can be called like when the caller does not have valid privileges. Bug: 1520906 Change-Id: I751b8342f214091bc886308d3e879bc14f875f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5225716 Commit-Queue: Sergio Villar <[email protected]> Reviewed-by: Min Qin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1251001}
Commits on Feb 1, 2024
-
-
Use generic-hand profile instead of generic-hand-select
The former does have a 3D model in the WebXR repository while the latter don't, that's why we don't show the hand model correctly in some experiences. Apart from that do insert the hand profile at the beginning of the list of profiles. Otherwise the physical controller profile would be selected first.
-
Add MagicLeap 2 WebXR input profile
We need to map the device type coming from Wolvic to a list of supported WebXR input profiles. This way WebXR experiences can properly render the 3D model of the actual controllers.
Commits on Feb 6, 2024
Commits on Feb 14, 2024
-
Add PageZoom APIs in Tab (#69)
The zoom factor map exists separately for Android and Desktop. This patch accesses the native PageZoom code to use desktop's zoom factor map. These APIs added in Tab will be used in the Zoom UI. Co-authored-by: Miyoung Shin <[email protected]>
Commits on Feb 16, 2024
-
Add setFactory for DateTime Prompt
This patches adds setFactory in DateTimeChooserAndroid to plumb the interface to a DateTime prompt.
Commits on Feb 21, 2024
-
Add Safe Json Java to Wolvic (#71)
This patch fixes the crash issue by safe json's Java class not being included in the package. Co-authored-by: Miyoung Shin <[email protected]>
Commits on Feb 27, 2024
-
[WebXR] Fix the stuck flow (#73)
The stuck flow issue is where new frame information is not gotten when SubmitFrameMissing is notified from the renderer. This patch adds a pending callback to prevent the sequence from stuck. Co-authored-by: Miyoung Shin <[email protected]>
-
[WebXR] Fix the white flash issues (#74)
The white flash issue is caused by we can't draw anything to the texture, but wolvic tries to draw the texture to the screen. This patch increase the frame index only when the frame is submitted. Co-authored-by: Miyoung Shin <[email protected]>
Commits on Feb 28, 2024
-
This patch fixes the issue that does not reflect the frame skip of the web page's intention by using vsync of wolvic. If the frame skip is requred, then `dropFrame` will be true, and Chromium will wait a next tick of vsync in wolvic side, and then will get a new frame's information.
Commits on Mar 1, 2024
-
Introduce skippable navigation entries (#76)
Allow browser to mark navigation entries as 'skippable' so that they are not used when performing back/forward navigation. This allows us to fix navigation issues caused by YouTube redirects to desktop app. This change also fixes a crash which happened when rapidly clicking back/forward button multiple times by ensuring that any navigation doesn't go out of bounds.
Commits on Mar 4, 2024
-
Replace WebVr references by WebXR
A legacy rationale is behind the usage of WebVr in the manager APIs. Some other APIs in Chromium were using the name of the old VR standard for the Web, but there is really no reason to use that instead of WebXR which is the one that arrived to stay.
-
Use gfx::Size instead of separate integers for WvrAPI
Instead of passing two integer arguments we can use a gfx::Size which already encapsulates an integer size in a single attribute. On the one hand it's more meaningful as it is now obvious that both sizes are related, and on the other hand it allows us to use the gfx::Size which is returned directly by other APIs without having to decompose it in its two components.
-
Use an enumerated type in PushState
It used to receive a boolean as single argument. The problem of using booleans in public APIs is that the caller does not really know what it does really mean, forcing developers to check the signature an implementation of the API. By using an enumerated type the callsites become self-explanatory.
Commits on Mar 6, 2024
-
This patch implements to support a HTTP Authentication's prompt that asks the user for a username and password when 401 or 407 status is received as an HTTP response.
Commits on Mar 8, 2024
-
This patch implements the file selection that uses `<input type=file>`. The selected file should be an absolute file path since the policy checking if the file can be read only allows the absolute file path.
Commits on Mar 11, 2024
-
Get rid of all testonly dependencies
Initially testonly flag was required by several content_shell related dependencies. Since then we reduced our dependency on content_shell heavily and this flag is no longer required. This patch removes all remaining test dependencies and gets rid of the testonly flag.
Commits on Mar 19, 2024
-
Do not let proguard remove Wolvic classes
When enabling minification in Wolvic, the Wolvic classes that are part of the Chromium tree are removed. This breaks many use cases, for example, WebXR does not work at all. By adding a keep rule for all Wolvic classes we manage to get a fully working minified packages.
-
Do not start duplicate permission dialogs (#83)
Update WolvicPermissionManager logic to prevent dialogs for identical permission requests from being started twice. This can happen when an Android activity is restarted due to a denied Android permission. In that case we want to rely on the initial user response instead of starting another user dialog.
-
Implement Android permissions support
Add a new parameter to PermissionManagerBridge.onPermissionRequest called "androidPermissionTypes" that contains names of Android permissions that must be requested for the corresponding content permission specified on "permissionTypes".
Commits on Mar 21, 2024
-
Expose SelectionPopupControllerImpl's interface to Wolvic
This CL adds the delegation in SelectionPopupController to expose the interface called by native to wolvic.
-
Replace a DCHECK by a null check
The call to GetJavaDelegate could return jobject whose obj() is null. That's why all the delegates in chromium code have a is_null() check after the aforementioned call. We instead had a DCHECK because we thought it was not possible to get a null object there but the truth is that sometimes we do and in those cases it was causing a crash on release builds. It's still unclear why it happens but we should avoid those crashes. When that obj() is null then we bail out and the navigation does not succeed. We haven't figured out yet which cases trigger those conditions too.
Commits on Apr 2, 2024
-
Request content and android permissions separately
This is a refactoring with no functional changes. We move logic that was implemented on the Wolvic side before to the backend side: - Requesting android permissions that match the corresponding content permissions. - Combining results of content and android permission requests to return them to the Content API. This is a precursor for microphone and camera permissions support, since it requires a third type of permissions: media permissions.
-
Use integers instead of enums in PermissionManagerBridge
Using enum is not recommended on Android: https://medium.com/android-news/android-performance-avoid-using-enum-on-android-326be0794dc3 Also, we'll be adding more enums for media permissions support and it'll be better to have them as integers to keep the code more consistent with wolvic.
Commits on Apr 4, 2024
-
Implement media permissions support (#90)
Extend functionality of WolvicPermissionManager to also support media permissions such as microphone and camera access. Media permissions are requested differently from other content permissions, the entry point for them is the WebContentsDelegate implementation. In this solution, we forward such calls from WolvicWebContentsDelegate to WolvicPermissionManager. The permissions manager first requests any required content and android permissions and only then requests media permissions via the PermissionManagerBridge class.
Commits on Apr 5, 2024
-
Repack resources pack to include other resources
This patch change to own Wolvic.pak for resources instead of content_shell.pak with repack resources pack to give a flexiblity including resources in out of //content.
-
Implement autocomplete's Login
- WolvicPasswordManagerClient for Login save - WolvicPasswordStorageBackend for Login DB - WolvicAutofillClient for autofill username/password - WolvicSignClient is dummy class to avoid crash issue - Changed components/autofill not to show suggestions of login whenever text field is changed. - WolvicRenderFrameObserver for binding Autofill Agent's mojo
Commits on Apr 9, 2024
Commits on Apr 10, 2024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.