Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The size of the fullscreen window is reset whenever we leave fullscreen mode #1593

Open
felipeerias opened this issue Oct 25, 2024 · 2 comments

Comments

@felipeerias
Copy link
Collaborator

Steps to Reproduce

  1. Play a video in e.g. YouTube
  2. open fullscreen mode
  3. change the size of the fullscreen window to e.g. 3X
  4. leave fullscren mode
  5. open again fullscreen mode

Note: the video keeps playing the whole time.

Current Behavior

The fullscreen window has the default size.

Expected Behavior

The fullscreen window has the last size that we selected (3X).

Possible Solution

Store the size of the fullscreen window and use it as the default when entering fullscreen mode.

@haanhvu
Copy link
Collaborator

haanhvu commented Nov 12, 2024

I'll work on this

@haanhvu
Copy link
Collaborator

haanhvu commented Nov 15, 2024

Current Behavior

The fullscreen window has the default size.

I have studied the code (here) and also tried out different cases. It doesn't seem like full screen window has a default size, but instead depends on the current size of the normal window, and fullscreen window is a bit bigger and closer than normal window?

This was what I saw:

  • Normal size: 1x => Fullscreen size: 1x
  • Normal size: 3x => Fullscreen size: 3x
  • Normal size 1x => Fullscreen size: 1x, increased to 3x => Exit then enter full screen again => Full screen size: 1x

So AFAIU the issue is about making the resizing of fullscreen separate from the size of normal screen?

Actually as a user I'd prefer to have the resizing of fullscreen dependent on the current size of normal screen. If the current size of normal screen is small (1x) then suddenly the size of fullscreen is so large (3x) and close, my eyes wouldn't feel comfortable. I'd prefer the fullscreen size to depend on the current normal size first, then I could resize later, no matter what was the last fullscreen size. Wdyt 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants