-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WarpDrive | Commit By Commit #2
Open
runspired
wants to merge
22
commits into
IgnaceMaes:master
Choose a base branch
from
runspired:talk-commits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
force-pushed
the
talk-commits
branch
from
September 12, 2024 01:11
256f4cf
to
28d9872
Compare
runspired
force-pushed
the
talk-commits
branch
2 times, most recently
from
September 12, 2024 08:03
7247dfd
to
f7bb44b
Compare
runspired
force-pushed
the
talk-commits
branch
from
September 12, 2024 12:44
f7bb44b
to
2e9b621
Compare
Did you end up deploying this anywhere? |
@NullVoxPopuli no, mostly because prod builds with workers in vite wasn't working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rework of #1 using meaningful commits (and a .gitignore on the generated API files) to support my EmberFest 2024 Talk. Also makes it easier to review here.