Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional adjustments to the Fleet Management sample app #20

Closed
IMinchev64 opened this issue Jan 17, 2025 · 0 comments · Fixed by #34
Closed

Additional adjustments to the Fleet Management sample app #20

IMinchev64 opened this issue Jan 17, 2025 · 0 comments · Fixed by #34
Assignees

Comments

@IMinchev64
Copy link
Contributor

For consistency can you assign type boolean to these two variables as well

Originally posted by @MarielaTihova in #10 (comment)

These values are used in several places ("ytd", "3months", "6months", "12months") . Can you put them in an Enum or some shared object?

Originally posted by @MarielaTihova in #10 (comment)

Interface for this so that you can assign a type to it

Originally posted by @MarielaTihova in #10 (comment)

Is there any reason to use == instead of === ?

Also can you put all flying around strings in variables? If they are repeating over different files, please put them in a shared location.

Originally posted by @MarielaTihova in #10 (comment)

Please use driverDetails?.name || "" instead of "as string". This will ensure us that we have an empty string if driverDetails.name has a falsy value. Same goes for all of the fields following

Originally posted by @MarielaTihova in #10 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant