fixing the --short-version glitches
#527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey :) just attempting to catch the attention of a reviewer, I don't mind using my own fork but if I'm not the only one the bug was... bugging, this would help. Let me know if you've got feedback to take care of before merging, if I missed a guideline or something, I'm never above improving ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
--short-versionglitches referenced in issue #526Description
Redirecting errors on
elixir --short-versionto/dev/nullseems to fix the problem on my machines I've tested on.Motivation and Context
Closes #526 (see for more details)
How Has This Been Tested
Adding the
2> /dev/nullredirection on both platforms makes the glitch disappears: no more unrequired additional new line added after the prompt, sometimes interrupting a command being typed nor--short-version : Unknown optionerror being haphazardly displayed.Checklist
Sorry, I don't know quite how to write tests for fish scripting, especially how to address such a glitch. As for the wiki, this being a bug fix, I'm not sure there needs to be an update? Let me know 🙂