Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on entering a directory with a package.json but node not installed #529

Open
will-stone opened this issue Sep 12, 2024 · 0 comments
Open
Labels
🐛 bug Something isn't working

Comments

@will-stone
Copy link
Contributor

will-stone commented Sep 12, 2024

Describe the bug

~/.config/fish/functions/_tide_item_node.fish (line 3):
        node --version | string match -qr "v(?<v>.*)"
        ^~~^
in function '_tide_item_node'
        called on line 15 of file ~/.config/fish/functions/_tide_2_line_prompt.fish

I have started using the mise tool to manage node versions, and when entering a directory with a node version that's not yet installed, it automatically fetches it. But during that time, the node command is technically not available for Tide to run, resulting in the above error. However the main issue here is that Tide tries to run node even if it's not available on the system.

Steps to reproduce

  1. Ensure node command not available.
  2. cd into a directory that includes a package.json file.
  3. See error above.

Screenshots

N/A

Environment

Output of tide bug-report:

fish version: 3.7.1
tide version: 6.1.1
term: xterm-256color
os: macOS 14.5
terminal emulator: WezTerm
fish startup: 273.70 millis
fisher plugins: jorgebucaran/fisher will-stone/fish-functions jethrokuan/z ilancosman/tide@v6

Additional context

Just to say thanks for all the work on this prompt! It's the best one I've seen on any shell; love the async stuff 🤓

@will-stone will-stone added the 🐛 bug Something isn't working label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant