Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements and hot fixes for version 3.0.0-alpha2 #88

Merged
merged 57 commits into from
Nov 28, 2024
Merged

Improvements and hot fixes for version 3.0.0-alpha2 #88

merged 57 commits into from
Nov 28, 2024

Conversation

manuGil
Copy link
Member

@manuGil manuGil commented Nov 28, 2024

In short:

  • Improvements to the cluster deployment files
  • Extend documentation
  • Improve validation
  • Fix bugs

Not fixed yet

  • automate deployment to cluster pi
  • complete documentation
  • generic solution for adding new models

joan-pijpker and others added 30 commits October 22, 2024 09:07
@joan-pijpker
Added support for new definition of the connection
d227905
@joan-pijpker
Added ChatGPT version of the script.
ca1ed92
@joan-pijpker
Improved the script and renamed to build_runshfile
566200d
@joan-pijpker
Corrected error message
17b6ddc
@joan-pijpker
Adjusted the readme.md file
573bf4a
@joan-pijpker
Corrected the readme.md file
c8364a8
@joan-pijpker
Corrected the readme.md file
33a0deb
@manuGil
Merge pull request #64 from Illuminator-team/remote-pi2
4027fc7 
Update to the cluster Pi code
@manuGil
Update cluster setup documentation to clarify server/client roles and…
50e0e28 
… improve instructions
@manuGil
add comments
d2a7db0
@manuGil
remove user guide from documentation
469c881
@manuGil
Refactor AdderModel step method to accept time parameter and print re…
6eb08ff 
…sult
@manuGil
Refactor builder_model_example.py to improve code readability and com…
e039184 
…ment out unused PV model code
@manuGil
Update adder.yaml to change model type from AdderModel to Adder for c…
2d68ac1 
…onsistency
@manuGil
Merge branch 'dev' into refac/models
47a9de2
@manuGil
Update documentation structure: remove deprecated user guide, rename …
9a2a589 
…start.md to set-up.md, and enhance setup instructions
@manuGil
Remove deprecated user guide references from documentation index
25652b8
@manuGil
Add developer/set-up.md to documentation index
a2f6031
@manuGil
Update cluster-setup.md and set-up.md for clarity and accuracy in set…
163806a 
…up instructions
@manuGil
create cluster package
12b07a5
@manuGil
Refactor CLI to use Typer for improved command handling and add scena…
5222741 
…rio and cluster subcommands
@manuGil
Enhance CLI help messages for scenario and cluster commands
9fa3a60
@manuGil
Update pyproject.toml to add Typer dependency and modify entry point …
e043349 
…for CLI
@manuGil
clean up test_engine.py
0504fc4
@manuGil
Remove unused validate_config_data function and its YAML import
07f3084
@manuGil
Add validate_config_data function for YAML configuration validation
a3202ba
@manuGil
Remove unused import of schema from illuminator.schemas.simulation in…
54c81fe 
… engine.py
@manuGil
Rename schemas directory to 'schema' and update validate_config_data …
7ac78e6 
…to support JSON output
@manuGil
Remove validate_yaml.py as it is no longer needed
1a316f2
@manuGil
rename alidate_config_data() to load_config_file()
94f7426
manuGil and others added 24 commits November 11, 2024 13:48
@manuGil
add TODO
252b3da
@manuGil
fix error with depricated validate_config_file()
6af3162
@manuGil
Merge pull request #81 from manuGil/refac/models
9b6d3c4 
Documentation and Interfaces
@manuGil
Update cluster setup documentation for clarity and completeness
33c3329
@manuGil
Add simulation configuration file documentation with YAML structure a…
5801771 
…nd examples
@manuGil
remove results from simulation schema
d813a11
@manuGil
update valid example for testing
652c69f
@manuGil
update unit tests for engine and simulation
32e0682
@manuGil
Update configuration file example with new scenario and model definit…
205a32a 
…ions
@manuGil
add build_runshfile.py to cluster package
6597133
@manuGil
Merge pull request #82 from manuGil/refac/models
5332479 
Missing build_runshfile
@manuGil
Refactor configuration keys in engine and simulation schema for clarity
f959d00
@manuGil
Update results file path in scenario_run function to use monitor conf…
e5aa4f3 
…iguration
@manuGil
Replace load_yaml with load_config_file in build_runshfile.py for imp…
bb220a1 
…roved configuration handling
@manuGil
Update README to replace 'master' with 'server' for clarity in Raspbe…
5254596 
…rry Pi setup instructions
@manuGil
Clarify monitor section in config-file.md by removing redundant infor…
2067287 
…mation about simulation results
@manuGil
Merge pull request #84 from manuGil/refac/models
0064688 
Fixes to bugs resulting from removing `results` from YAML file
@manuGil
Implement Simulation class to manage and run simulations with configu…
2654899 
…ration file loading
@manuGil
Refactor scenario_run function to utilize Simulation class
5d2d41d
@manuGil
Add simulations documentation and update index.rst for navigation
28fa80b
@manuGil
Merge pull request #85 from manuGil/refac/models
f2e94f5 
Add Python interface
@jgrguric96
Current status: No longer has error on missing parameter
2070e73
@jgrguric96
Creation stage has issues fixed. Currently on build_connections.
67d6dfe
@manuGil
Merge pull request #86 from jgrguric96/hotfix/ModelConstructor
643ab08 
Hotfix collection for ModelConstructor class
@manuGil manuGil added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Nov 28, 2024
@manuGil manuGil self-assigned this Nov 28, 2024
@manuGil manuGil marked this pull request as ready for review November 28, 2024 09:54
@manuGil manuGil merged commit 1055efd into main Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@manuGil manuGil

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuGil @joan-pijpker @jgrguric96