Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Cleanup #160

Open
7 of 18 tasks
GeBo1 opened this issue Jan 5, 2024 · 1 comment
Open
7 of 18 tasks

[DRAFT] Cleanup #160

GeBo1 opened this issue Jan 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@GeBo1
Copy link
Collaborator

GeBo1 commented Jan 5, 2024

Tracking things to be cleaned up after merging (List is still WIP)

Nested Quotes

  • Should be opening double, opening single, closing single, closing double, like this:
    “outer blah ‘nested’, outer”

Pastor (牧師) Dialog

  • Common lines spoken by the Pastor should be unified across different personalities.

Check for conflicting translations

  • Ensure the same dialog lines within a single personality are translated the same when in different assets

Find Regex errors

  • Some lines when updated by regex in the past have injected $3, $4 etc in the translations

Ellipsis corruption

  • At least one case where ... became ,,,.

Missing apostrophes

  • Im -> I'm
  • cant -> can't
  • etc.

Capitalization issues

  • Some cases where ellipsis or * was replaced with , the next word is still capitalized: So, What do you want? -> So, what do you want?

  • Stuttered words that start a sentence should only capitalize the first letter Y-Yes -> Y-yes.

Strange punctuation

  • [Noise]--, [dialog]
  • blah?... -> blah...?

British vs American spelling

  • Standardize on American

Non-words

Some incorrect compound words are in a number of places.

  • atleast -> at least
  • afterall -> after all
  • lovenest -> love nest

Protagonist dialog consistency

  • Lines spoken by the protagonist across all personalities could probably use some harmonization.

Club talk

  • When コイカツ is used it should be translated as Koikatsu (rather than treating it like 恋勝つ) and the words used to explain what it is should be similar
@GeBo1 GeBo1 added the enhancement New feature or request label Jan 5, 2024
@GeBo1 GeBo1 self-assigned this Jan 5, 2024
@ManlyMarco
Copy link
Collaborator

Could not find any other regex errors.

Other checked issues addressed in #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants