Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a Script class #102

Open
offero opened this issue Feb 9, 2016 · 2 comments
Open

Add support for a Script class #102

offero opened this issue Feb 9, 2016 · 2 comments

Comments

@offero
Copy link

offero commented Feb 9, 2016

I made this object for my own use that mimics the one from the redis-py driver: https://bitbucket.org/wanderua/wanderu.bamboo/raw/74aeda47a1764284d137fec437d73eb8047d5b98/wanderu/bamboo/txscript.py
That's from an open-source project that I am making for using Redis as a queuing mechanism with reliability. I would gladly contribute it or some version of it to the core library if you think that would be useful.

The redis driver has a Script class that is pretty useful: https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L2676

@fiorix
Copy link
Collaborator

fiorix commented Feb 9, 2016

That's cool, contributions are definitely welcome. I haven't been maintaining this and any of my previous python code, but would be happy to review and eventually take patches. @IlyaSkriblovsky has been more actively.

As far as the script capabilities of redis, yes, aware of them... implemented this in my go-redis driver a while back.

On Feb 9, 2016, at 10:23 AM, Chris [email protected] wrote:

I made this object for my own use that mimics the one from the redis-py driver: https://bitbucket.org/wanderua/wanderu.bamboo/raw/74aeda47a1764284d137fec437d73eb8047d5b98/wanderu/bamboo/txscript.py https://bitbucket.org/wanderua/wanderu.bamboo/raw/74aeda47a1764284d137fec437d73eb8047d5b98/wanderu/bamboo/txscript.py
That's from an open-source project that I am making for using Redis as a queuing mechanism with reliability. I would gladly contribute it or some version of it to the core library if you think that would be useful.

The redis driver has a Script class that is pretty useful: https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L2676 https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L2676

Reply to this email directly or view it on GitHub #102.

@IlyaSkriblovsky
Copy link
Owner

Please make the PR from this nifty piece of code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants