Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to make notebooks more readable/usable #46

Open
fedorov opened this issue Jan 3, 2024 · 0 comments
Open

Small improvements to make notebooks more readable/usable #46

fedorov opened this issue Jan 3, 2024 · 0 comments

Comments

@fedorov
Copy link
Member

fedorov commented Jan 3, 2024

Some of the items I noticed, which are hopefully not too difficult to fix:

  • instead of commenting out installation of prerequisites, it is better to put those into an if clause, which would check whether papermill-initialized variable (say, "interactive") is reset
  • if the notebook is executed in the "colab" (interactive) mode, it would be good to make it possible to run it without assuming that manifest file is present, and instead generate it on the fly, or use pre-defined SeriesInstanceUIDs, so that the notebook is completely self-contained
  • I noticed that in some cases global variables are used - it would be good to get rid of those and instead use function parameters for passing these variables
  • things such as SeriesNumber may be easiest to fetch from the input CT series instead of relying on the manifest or query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant