Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow segmentations to reference multiple images #199

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Allow segmentations to reference multiple images #199

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
18fc8f4
Allow more than one multi-frame source images
hackermd Aug 22, 2022
15a7169
Add checks to ensure similarity of source images
hackermd Aug 30, 2022
ddc14c5
Simplify formatting of log messages
hackermd Aug 30, 2022
ead8a30
Include references to all source image frames
hackermd Aug 30, 2022
fc5b2d1
Add test for multiple multi-frame source images
hackermd Aug 30, 2022
194b1d3
Include references for multiple single-frame images
hackermd Aug 30, 2022
0b01806
Fix uniqueness check for source images
hackermd Aug 30, 2022
88d03c3
Allow reference of images from multiple series
hackermd Oct 10, 2022
7d5a4b1
Fix coding style issue
hackermd Oct 10, 2022
29f5389
Clarify requirements for source images
hackermd Oct 10, 2022
8f154d8
Update src/highdicom/seg/sop.py
hackermd Oct 11, 2022
a2c0d1d
Handle multi-frame images consistently
hackermd Oct 11, 2022
03ce387
Merge branch 'bugfix/segmentation-source-images' of github:herrmannla…
hackermd Oct 11, 2022
5889b6b
Apply suggestions from code review
hackermd Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/highdicom/seg/sop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,11 +292,6 @@ def __init__(

src_img = source_images[0]
is_multiframe = hasattr(src_img, 'NumberOfFrames')
if is_multiframe and len(source_images) > 1:
raise ValueError(
'Only one source image should be provided in case images '
'are multi-frame images.'
)
is_tiled = hasattr(src_img, 'TotalPixelMatrixRows')
supported_transfer_syntaxes = {
ImplicitVRLittleEndian,
Expand Down