Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beef up ring homomorphism to an algebra homomorphism task #218

Merged
merged 9 commits into from
Nov 17, 2024

Conversation

WilliamCoram
Copy link
Contributor

@WilliamCoram WilliamCoram commented Nov 15, 2024

Claimed task from project

Closes #205

Copy link
Collaborator

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made some suggestions which make the code more idiomatic but if you're happy with the suggestions then feel free to commit them and then I'll merge.

FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
@WilliamCoram
Copy link
Contributor Author

Cheers! I have committed your suggestions.

@kbuzzard kbuzzard merged commit afa70b6 into ImperialCollegeLondon:main Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beef up a ring homomorphism to an algebra homomorphism
2 participants