Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change voltage limits in plot #104

Open
tomjholland opened this issue Aug 28, 2024 · 4 comments
Open

Add ability to change voltage limits in plot #104

tomjholland opened this issue Aug 28, 2024 · 4 comments
Labels
frontend Related to the user interaction layer (GUI, UI or UX)

Comments

@tomjholland
Copy link
Collaborator

No description provided.

@tomjholland tomjholland added the frontend Related to the user interaction layer (GUI, UI or UX) label Aug 28, 2024
@brosaplanella
Copy link

I am happy to give a go at this one (if I understand correctly what you had in mind). Which API where you thinking of?

@tomjholland
Copy link
Collaborator Author

Hi Ferran, thanks and sorry for the vague issue description! I think this is a pretty simple issue:

So my Plot class uses plotly and this issue was to just fix the implementation of axes limits. The Plot class has x_max, x_min, y_max, y_min attributes which can be used to control the axes limits, but the actual plot adds some pad to this with the x_range and y_range properties, so the displayed limits are wider than the user requests:
Screenshot 2024-09-27 at 10 07 35

The solution I think is probably just to add a setter for x_range and y_range to allow users to override the axes limits directly, and make the *_min and *_max attributes private.

@brosaplanella
Copy link

Cool! Will try to give it a go, if that's fine, but term is starting next week so if you don't hear from me and you need this done just go ahead.

@tomjholland
Copy link
Collaborator Author

Of course, no problem at all! I'm very grateful that you are keen to contribute and understand completely that you will have many other things to spend your time on 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to the user interaction layer (GUI, UI or UX)
Projects
None yet
Development

No branches or pull requests

2 participants