Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Test for table partial views test nothing #155

Open
dalonsoa opened this issue Oct 14, 2024 · 0 comments
Open

[BUG] Test for table partial views test nothing #155

dalonsoa opened this issue Oct 14, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dalonsoa
Copy link
Collaborator

Most tests in the TestProcessTableView have checks like:

        for row in table.data.data:
            assert row["checked"] == (row["uuid"] in selected_uuids)

The problem is that table.data.data actually is an empty list, so none of these assert statements are run. To check that, just add a breakpoint() in front of assert: it is never called.

I've no idea why this is the case, but I suspect that the ProcessTable here cannot make a table out of a list of dictionary full of mocks. As far as I can tell, there's no warning.

Or, more likely, this mock here is not working as it should because if we check the contents of table_data before calling ProcessTable, such table is empty, suggesting that the ProcessSessions is not... iterating.

Whatever the reason, something is not right in these tests.

@dalonsoa dalonsoa added the bug Something isn't working label Oct 14, 2024
@AdrianDAlessandro AdrianDAlessandro self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants