Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor timeseries #105

Open
barneydobson opened this issue Sep 23, 2024 · 0 comments
Open

Refactor timeseries #105

barneydobson opened this issue Sep 23, 2024 · 0 comments

Comments

@barneydobson
Copy link
Collaborator

barneydobson commented Sep 23, 2024

Not urgent - but a discussion thread for how data is saved/loaded for WSIMOD models. The current setup is enormously timeconsuming and can make debugging rather hard.

Currently each timeseries is must be converted into the wsimod to_datetime format (which I think is what is taking so long) and stored as keys.

pandas would be the sensible alternative but I avoided it to minimise dependencies - possible it could be optional - and if present used to speed things up a lot.

would probably need to feature in both the model save and load to allow conversion of existing non-pandas models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant