Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions release #107

Closed
14 tasks done
barneydobson opened this issue Oct 2, 2024 · 4 comments
Closed
14 tasks done

Extensions release #107

barneydobson opened this issue Oct 2, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@barneydobson
Copy link
Collaborator

barneydobson commented Oct 2, 2024

Issue to discuss finalisation of the new extensions ability.

Below copied from #99

Within #97 - @dalonsoa

  • Create extensions_register
  • Create register_node_method (optional arg for sub_object).
  • Add apply_decorators
  • Tests (make tests that can be used in docs)

Within this PR - @dalonsoa

  • Implement sequence above
  • Tests (make tests that can be used in docs)

Close #54 , make a new PR - @liuly12

  • Keep the custom orchestration stuff, bin else

Enable custom subclasses

Documentation (new issue)

@barneydobson barneydobson added the enhancement New feature or request label Oct 2, 2024
@barneydobson
Copy link
Collaborator Author

@dalonsoa did we have a plan to add custom classes - I know it can be done by updating the registry but there's no way to enter those in the normal config use. You could add them to be loaded by load_extension_files - but this would need to take place before add_nodes since the subclasses will need to have been registered before that point

@dalonsoa
Copy link
Collaborator

dalonsoa commented Oct 2, 2024

I don't remember if we ditched the idea, or just forgot to include it in the plan above. In any case, it should be as simple as moving this line:

load_extension_files(data.get("extensions", []))

To before adding the nodes. The extensions files can have decorated stuff but also extra classes, so they all should be "registered" together. I don't think there's any reason for loading the extension files at the end rather than at the beginning.

@barneydobson
Copy link
Collaborator Author

I will add that to the list of tasks above

@barneydobson
Copy link
Collaborator Author

will be fixed by #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants