-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions release #107
Comments
@dalonsoa did we have a plan to add custom classes - I know it can be done by updating the registry but there's no way to enter those in the normal config use. You could add them to be loaded by |
I don't remember if we ditched the idea, or just forgot to include it in the plan above. In any case, it should be as simple as moving this line: wsi/wsimod/orchestration/model.py Line 223 in 61573a9
To before adding the nodes. The extensions files can have decorated stuff but also extra classes, so they all should be "registered" together. I don't think there's any reason for loading the extension files at the end rather than at the beginning. |
I will add that to the list of tasks above |
will be fixed by #127 |
Issue to discuss finalisation of the new extensions ability.
Below copied from #99
Within #97 - @dalonsoa
extensions_register
register_node_method
(optional arg forsub_object
).apply_decorators
Within this PR - @dalonsoa
Close #54 , make a new PR - @liuly12
Enable custom subclasses
load_extension_files
to occur beforeadd_nodes
#108Documentation (new issue)
register_node_handler
) - us to revisitThe text was updated successfully, but these errors were encountered: