Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable overrides #72

Closed
3 of 11 tasks
barneydobson opened this issue Feb 29, 2024 · 3 comments
Closed
3 of 11 tasks

Enable overrides #72

barneydobson opened this issue Feb 29, 2024 · 3 comments
Labels
overrides

Comments

@barneydobson
Copy link
Collaborator

barneydobson commented Feb 29, 2024 •
edited by liuly12
Loading

An issue to keep track of all the different things that (may) need apply_overrides behaviour defined for (linked with #66 and #54)

  • Node
  • WTW/WWTW
  • FWTW [Under review]
  • Land Enable overrides in Land node #71 [Under reivew]
  • NutrientPool Enable overrides in Land node #71 [Under reivew]
  • Catchment [No additional parameters to be updated]
  • Demand (and subclasses) [Under review]
  • Distribution (and subclasses) [Under review]
  • Sewer [Under review]
  • Storage (and subclasses) [Wait to be merged]
  • Waste - not necessary
@liuly12
Copy link
Collaborator

liuly12 commented Mar 1, 2024

@barneydobson Should overrides be added to Tank and its superclasses (e.g., ResidenceTank, DecayTank, etc.) as well?

@barneydobson
Copy link
Collaborator Author

I'm not sure it's necessary as you don't substantiate a Tank from a config file. All Tanks are specific to their node class

@barneydobson
Copy link
Collaborator Author

think these are all done now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
overrides
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barneydobson @liuly12