Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posting Issues issue #17

Open
EHLOVader opened this issue Jun 1, 2015 · 0 comments
Open

Posting Issues issue #17

EHLOVader opened this issue Jun 1, 2015 · 0 comments

Comments

@EHLOVader
Copy link

@devcflynn in #16 you suggested that your fork https://github.com/devcflynn/blacksmith should be used as you plan on actively developing this with Indatus going forward.

Issues aren't turned on, and as I look to this project to potentially use in a personal workflow I have run into a few issues I would like to document as well as next steps I feel might be good to discuss or look into for the move to Laravel 5.

Should I be posting those here? on your fork... or on mine? I started on mine but just discovered a few other pain points from the original implementation

Also not sure it would actually stem from https://github.com/brianwebb01/hexagonal-laravel-experiment or this but the creationFailedValidation you use in the Creator isn't a part of the interface contract or initially implemented. As well as the delete method in the repositories which isn't initially implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant