Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ideas #1

Open
Johnnywick1 opened this issue Feb 1, 2024 · 6 comments
Open

New ideas #1

Johnnywick1 opened this issue Feb 1, 2024 · 6 comments

Comments

@Johnnywick1
Copy link

Nice app, but I have a few ideas:

  1. Is it possible that after entering the website it will automatically load the location (without permission because Google does not like applications forcing permissions?) Is it posible that after refreshing, the page remembers its previous location? (like here: https://my-weather-app-wm.netlify.app/)

  2. Is it possible to add (for hours and per day) data such as: Wind, Humidity, Cloud Cover, Precipitation with mm and Precipitation with %, Percipation Hours, (and AQI, UV Index not necessarily)? More data more better for users.

  3. Is it possible to add swipe buttons so that the swipe bar is not visible? (like here https://misterf1x.github.io/WeatherAPP/)
    Sorry for my english. That's all for now.

  4. Is it possible when you change the units from Celsius to Fahrenheit also change the wind speed units from kmp/h to mp/h?

Thank you

@Johnnywick1
Copy link
Author

hanks for considering my ideas. If you had free time (and wanted to do this), could you improve the script to have a better Cumulative Layout Shift result? It's very bad performance on mobile? Check on https://pagespeed.web.dev if you want. Google doesn't like bad performance ;/

Thank you once again

@Johnnywick1
Copy link
Author

... and I found 1 issue too... when i choose some city the hourly hours show my local time, not local time the city I choose

@InesZenkri
Copy link
Owner

Thank you for taking the time to test it out. Your insights have been invaluable in enhancing the project, the current version is not the final product, as I am still working on refining it. I welcome any additional suggestions or ideas you may have, as I am always open to improving and iterating upon the project. (didn't notice the hourly hour thing 🤭 thx for mentioning it )

@Johnnywick1
Copy link
Author

If you have time you can add Precipitation with mm (metric), inch (imperial) and Precipitation with % below the Humidity and Wind in Daily windows. It can be helpful for users. I think the WeatherAPI shares these data.

Can you try add async or defer to the javascripts? In Pagespeed there is a info: "Reduce unused JavaScript and defer loading scripts until they are required to decrease bytes consumed by network activity" for:

…js/main.bbeeec32.js(ineszenkri.github.io) 129.1 KiB 69.4 KiB
../node_modules/react-dom/cjs/react-dom.production.min.js 37.5 KiB 14.7 KiB
../node_modules/leaflet/src/map/Map.js 6.1 KiB 5.6 KiB
../node_modules/luxon/src/datetime.js 5.9 KiB 4.4 KiB
../node_modules/leaflet/src/layer/tile/GridLayer.js 3.0 KiB 2.7 KiB
../node_modules/luxon/src/duration.js

I don't know if it help but you can try add async or defer to the javascripts.

Thanks

@Johnnywick1
Copy link
Author

Thank you for changes. Sorry to bother you again, but I noticed some issues.

  1. The icons representing the weather status do not correspond to the description, e.g.
    description: Heavy rain - icon: only cloud,
    description: Light rain -> icon: only cloud,
    description: Patchy rain nerby -> icon: cloud with sun without rain

I didn't check the rest of the icons.

  1. Thanks for the correction of refreshing the page and leaving the last location in memory, but when I turn on the page for the first time, e.g. in incognito mode, a pop-up window appears in browser that forces me to allow the location. Google doesn't like this. Here's a page about it: https://developer.chrome.com/docs/lighthouse/best-practices/geolocation-on-start?hl=en

And here are probably the solutions:

Here's the app I sent you earlier and it doesn't have this problem (https://my-weather-app-wm.netlify.app/). It searches for a location automatically without asking for the user's consent, and that's exactly what it's all about. In this app Google doesn't see a problem. This app uses the https://ipwhois.io/ API, but I don't recommend it because it doesn't point to a proper location. I'll just show you that you can do it.
Unless you are unable to do this, my advice is that after entering your website there should be one permanent city, for example New York, and only then the user selects his city, and after refreshing the location which chose is saved.

Thank you once again and sorry for my English

@Johnnywick1
Copy link
Author

Hello again,

I have one more request for you. Could you add Next Previous buttons to the script, because on desktops it is difficult to scroll using keyboard arrows. It's better to do it by clicking the buttons. Please add these buttons to Hourly and Daily forecast (if it is a 14-day forecast)

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants