Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft dungeons weapons are labeled tools instead weapons dungeons_gear-1.18.2-4.0.2 #219

Open
Sageking10 opened this issue Feb 11, 2023 · 2 comments
Labels
bug Something isn't working Compatibility When other mods just don't. enhancement New feature or request

Comments

@Sageking10
Copy link

Thanks to the mod Obscure tooltips, I found out that the melee weapons are labeled as tools instead of weapons, which most likely causes them to lose durability to the target dummy from the MmmMmmMmmMmm mod.
2023-02-11_00 19 00
2023-02-11_00 19 15

@Thelnfamous1
Copy link
Collaborator

Thelnfamous1 commented Feb 12, 2023

I think there's a case to be made for changing our melee weapons to be SwordItem based in our code, to prevent issues such as this.

@Thelnfamous1 Thelnfamous1 added bug Something isn't working enhancement New feature or request labels Feb 18, 2023
@Thelnfamous1
Copy link
Collaborator

Thelnfamous1 commented Feb 18, 2023

@Sageking10, Can you make a request to the Obscure Tooltips devs that they change their system to identify weapons as those containing the "Sword Sweep" Tool Actions or similar?

@Thelnfamous1 Thelnfamous1 added the Compatibility When other mods just don't. label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Compatibility When other mods just don't. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants