Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Supporting multiple domains #16

Open
iakat opened this issue Mar 1, 2019 · 9 comments
Open

Supporting multiple domains #16

iakat opened this issue Mar 1, 2019 · 9 comments

Comments

@iakat
Copy link

iakat commented Mar 1, 2019

Hello!

Is there support for multiple oauth domains?

Thanks.

@InfoSec812
Copy link
Owner

I'm not sure how that would work with Google OAuth. I'd be happy to review a pull request.

@trajano
Copy link

trajano commented Apr 15, 2019

Wouldn't this be a matter of checking the email address being returned in the user profile can confirming it is in the whitelist specified in sonar.auth.googleoauth.limitOauthDomain

@InfoSec812
Copy link
Owner

@trajano The limitOauthDomain is a setting which is sent as part of the OAuth challenge to Google, so the domain needs to be determined BEFORE the flow begins.

@roelandpinch
Copy link

We needed this support as well and changed the code, and we are testing it now. Perhaps this can be useful for you as well @chauffer ?
roelandpinch@2625885

@iakat
Copy link
Author

iakat commented Jun 4, 2019

Thank you very much for the tag @roelandpinch! It will be useful.

@InfoSec812
Copy link
Owner

@roelandpinch Would you mind submitting a PR and we'll get this integrated?

@roelandpinch
Copy link

@InfoSec812 Sure, I have submitted the PR!

@ErenPhayte
Copy link

ErenPhayte commented Jul 19, 2021

Has this been reviewed yet? Just came across the same issue.

#22

@InfoSec812
Copy link
Owner

As mentioned in the project README:

This Plugin Is No Longer Maintained

After trying to keep this updated for some time, I have just not been able to with all of my other demands. If anyone would like to take this project over, you are welcome to. As an alternative, you can use oauth2-proxy and HTTP Header Authentication to support ANY OAuth2/OIDC provider.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants