Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Right Links WE on user-defined sites #11

Open
Gitoffthelawn opened this issue Jan 20, 2019 · 4 comments
Open

Disable Right Links WE on user-defined sites #11

Gitoffthelawn opened this issue Jan 20, 2019 · 4 comments

Comments

@Gitoffthelawn
Copy link
Contributor

Although I try to stay away from Google products, Google Maps is still sometimes the best choice for certain tasks.

To use Google Maps efficiently, allowing right-clicking on the map itself is very useful, to display the context menu. On the other hand, using Right Links WE to open other links on that site in a new tab is also useful.

Is there any way to only disable Right Links WE from opening links in a new tab when right-clicking on the map?

I don't want to completely disable handling clicks on images on all sites.

Thanks you again for Right Links WE... it is extraordinarily useful! 👍

@Infocatcher
Copy link
Owner

Is there any way to only disable Right Links WE from opening links in a new tab when right-clicking on the map?

Currently no... but on Google maps used canvas image and there is on/off checkbox + size limit for canvas.

@Gitoffthelawn
Copy link
Contributor Author

Thanks for your reply. 😄

Unfortunately, the canvas checkbox is applied globally, and I want Right Links WE to be enabled on most canvas objects.

So how about we have this as a feature request. 👍

@Infocatcher Infocatcher changed the title Right Links WE with Google Maps Disable Right Links WE on user-defined sites Jan 26, 2019
Infocatcher added a commit that referenced this issue Feb 2, 2019
Infocatcher added a commit that referenced this issue Feb 2, 2019
@Infocatcher
Copy link
Owner

Added separate blacklists for left-click and right-click.
Test version (about:debugging – Load Temporary Add-on):
right_links_we-0.5b9pre.xpi (source code)

Pattern for Google Maps: /^https?://www\.google(?:\.\w+){1,2}/maps//

@Gitoffthelawn
Copy link
Contributor Author

Looking great so far! Thank you! 👍

Since you're in development mode, I thought I would expand on my comments above. When reading them again, in hindsight, I could have been more clear. Sorry about that.

Ideally, it would be great if Right Links WE could allow right-clicking on certain elements of a page (the map itself, in the Google Maps example) using the normal right-click functionality, and still allow Right Links WE to process right-clicks on other areas of the same page.

I hope that the above adds clarity to what I originally wrote. Let me know if it doesn't! :-)

Infocatcher added a commit that referenced this issue Mar 13, 2021
(#11, bug in 31349eb commit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants