Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spanish translation to intro -> how IS works #394

Merged
merged 3 commits into from
May 3, 2021
Merged

Add Spanish translation to intro -> how IS works #394

merged 3 commits into from
May 3, 2021

Conversation

dicortazar
Copy link
Member

@dicortazar dicortazar commented Apr 11, 2021 •
edited by rrrutledge
Loading

@dicortazar dicortazar requested a review from a team as a code owner April 11, 2021 18:43
@dicortazar dicortazar requested a review from rrrutledge April 11, 2021 18:44
@dicortazar dicortazar linked an issue Apr 15, 2021 that may be closed by this pull request
Translate "Introduction" articles to Spanish #383
Open
6 tasks
@rrrutledge
Copy link
Contributor

Thanks for this pull request, Daniel! I am on vacation now but will see when I get back next week if I can take a look.

rrrutledge
rrrutledge requested changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this submission! Sorry for the delay in review. A few comments.

introduction/es/03-how-works.asciidoc Outdated Show resolved Hide resolved
introduction/es/03-how-works.asciidoc Show resolved Hide resolved
introduction/es/03-how-works.asciidoc Outdated Show resolved Hide resolved
dicortazar and others added 2 commits May 3, 2021 12:38
@dicortazar @rrrutledge
Update introduction/es/03-how-works.asciidoc
0827ff8 
Signed-off-by: Daniel Izquierdo Cortazar <[email protected]>

Co-authored-by: rrrutledge <[email protected]>
@dicortazar @rrrutledge
Update introduction/es/03-how-works.asciidoc
d24b618 
Signed-off-by: Daniel Izquierdo Cortazar <[email protected]>

Co-authored-by: rrrutledge <[email protected]>
@dicortazar
Copy link
Member Author

Thanks for the suggestions @rrrutledge , I think I've covered all of them.

rrrutledge
rrrutledge approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rrrutledge rrrutledge merged commit 7fc40f6 into InnerSourceCommons:master May 3, 2021
@rrrutledge
Copy link
Contributor

Opened a pull request to put it on the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrrutledge rrrutledge rrrutledge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate "Introduction" articles to Spanish
2 participants
@dicortazar @rrrutledge