Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learning Path video updated #132

Closed
clcoffey opened this issue Jun 29, 2021 · 8 comments · Fixed by #133
Closed

Learning Path video updated #132

clcoffey opened this issue Jun 29, 2021 · 8 comments · Fixed by #133
Labels
bug Something isn't working

Comments

@clcoffey
Copy link
Collaborator

Describe the bug
We have updated the Learning Path Become an InnerSource Contributor Video on Youtube. This has broken the link on the website: https://innersourcecommons.org/learn/learning-path/contributor/02/

Expected behavior

The new video link is: https://youtu.be/S0Gps2AbZ7M
Please update the link on the website so that the new video will be embedded and will play in the page.

Additional context
This issue is related to the Learning Path issue #122

@clcoffey clcoffey added the bug Something isn't working label Jun 29, 2021
@clcoffey
Copy link
Collaborator Author

@tsadler1988 and @voborgus is there any chance you could help with this?

@voborgus
Copy link
Collaborator

The easiest and the ugly way is to change the youtubeCode directly:
image

But much better to wait for @tsadler1988 for correct change with re-generation from learning path sources.

@tsadler1988
Copy link
Collaborator

tsadler1988 commented Jun 29, 2021

For now there are quite a few manual steps:

  1. Update the URL in the config
  2. Open a PR on https://github.com/InnerSourceCommons/InnerSourceLearningPath
  3. Get the PR merged
  4. Regenerate the Learning Path markdown
  5. Open a PR on https://github.com/InnerSourceCommons/innersourcecommons.org
  6. Once PR is merged the website will update automatically

Steps 4 and 5 will be automated soon...if you're keen to get this out quickly then maybe update directly for now as @voborgus said, although please do steps 1-3 above to avoid the URL reverting to the old video.

@clcoffey
Copy link
Collaborator Author

Thanks @tsadler1988 and @voborgus
I've done steps 1 & 2 in Tom's list.
Waiting for step 3

clcoffey added a commit that referenced this issue Jun 30, 2021
@clcoffey
Copy link
Collaborator Author

Ok, it took me a while but I managed to get through all the steps :-)

@tsadler1988
Copy link
Collaborator

I think there's 1 missing step on the YouTube side - the new video doesn't seem to have a proper thumbnail (https://img.youtube.com/vi/v3aRZkbTSmY/mqdefault.jpg). Not sure how to do this I'm afraid, but these are used on the website so could do with being updated.

I'm not sure if we have copies of the thumbnails anywhere, but re-using the old video's thumbnail should be fine.

@voborgus
Copy link
Collaborator

voborgus commented Jul 1, 2021

@tsadler1988 seems the URL for thumbnail in this PR is correct and working and we can merge this:
https://img.youtube.com/vi/S0Gps2AbZ7M/mqdefault.jpg

@tsadler1988
Copy link
Collaborator

Ohh I was looking at the old video ID - my mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants