Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum for valid label types #72

Closed
nsenave opened this issue Sep 12, 2022 · 1 comment · Fixed by #124
Closed

Enum for valid label types #72

nsenave opened this issue Sep 12, 2022 · 1 comment · Fixed by #124
Assignees
@nsenave

Comments

@nsenave
Copy link
Contributor

nsenave commented Sep 12, 2022 •
edited
Loading

A LabelType object has been introduced (replacing String labels).

The value attribute corresponds to the former String labels.

The type attribute is a String, so clients a free to write anything they want in label types. I suspect that the Lunatic library expects precise values for this, and it would not be best to have these values hard-coded in each client application.
@nsenave nsenave mentioned this issue Dec 5, 2022
Open
@nsenave nsenave mentioned this issue Nov 28, 2023
Merged
@nsenave nsenave self-assigned this Nov 28, 2023
@nsenave nsenave changed the title [dev-lunatic-v2] Enum for valid label types. Enum for valid label types Nov 28, 2023
@nsenave nsenave linked a pull request Nov 28, 2023 that will close this issue
refactor: create enum class for label type #124
Merged
@nsenave
Copy link
Contributor Author

nsenave commented Apr 29, 2024

a2f2514

@nsenave nsenave closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsenave nsenave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: create enum class for label type InseeFr/Lunatic-Model
1 participant
@nsenave