[dev-lunatic-v2] Usage of LabelType in ConditionFilterType?

[nsenave]

The LabelType has been introduced to replace String labels by an object that contains metadata about the concerned language (VTL / MD). This object is not used in the ConditionFilterType, which seems a bit odd.

I suggest something like this:

https://github.com/InseeFr/Lunatic-Model/blob/dev-lunatic-v2/src/main/resources/xsd/LunaticModelFlat.xsd#L85

    <xs:complexType name="ConditionFilterType">
        <xs:sequence>
            <xs:element name="expression" type="labelType"/>
            <xs:element name="bindingDependencies" type="xs:string" minOccurs="0" maxOccurs="unbounded"/>
        </xs:sequence>
    </xs:complexType>

https://github.com/InseeFr/Lunatic-Model/blob/dev-lunatic-v2/src/main/resources/xsd/LunaticModel.xsd#L92

    <xs:complexType name="ConditionFilterType">
        <xs:sequence>
            <xs:element name="expression" type="labelType"/>
            <xs:element name="bindingDependencies" type="xs:string" minOccurs="0" maxOccurs="unbounded"/>
        </xs:sequence>
    </xs:complexType>

Note:

These changes could also affect the "json-cleaner.xsl" script:

https://github.com/InseeFr/Lunatic-Model/blob/dev-lunatic-v2/src/main/resources/xslt/json-cleaner.xsl

and Eno's branch dev-lunatic-v2

https://github.com/InseeFr/Eno/blob/dev-lunatic-v2/src/main/resources/xslt/transformations/ddi2lunatic-xml/ddi2lunatic-xml-fixed.xsl#L739

[nsenave]

The changes from #101 have been reverted, I'll leave it like this for now.

As it is, the ConditionFilterType is somewhat a particular LabelType (it is a label that has binding dependencies in it).

We will remove the ConditionFilterType entirely, and simply replace it with LabelType, when binding dependencies will no longer be used in the condition filter properties in Lunatic.