Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation errors, design analysis #515

Closed
romaintailhurat opened this issue Nov 29, 2021 · 2 comments
Closed

Generation errors, design analysis #515

romaintailhurat opened this issue Nov 29, 2021 · 2 comments
Assignees

Comments

@romaintailhurat
Copy link
Collaborator

As previously described, we want to provide to users a clearer message when an error occurred during the generation phase.

Before we actually work on this issue, an analysis must be done in order to understand what should be done and where:

  • at the Pogues level, before we communicate to the Eno API ?
  • at the Eno API level, and therefore in Pogues to display in return a proper error message ?
  • what about errors only happening at the questionnaire side (ie not raised by Pogues and / or Eno) ?
@romaintailhurat
Copy link
Collaborator Author

romaintailhurat commented Dec 2, 2021

After debating, we will work on the problem through two issues:

  1. in Pogues, check if a variable used in a control is declared
  2. in Pogues again, catch a 500 status code from the Eno API in order to display a readable error message.

@ORogel
Copy link
Contributor

ORogel commented Dec 7, 2021

Some random thoughs:

  • an API taking more than 5 minutes to answer should not be a thing
  • we need to catch as many errors as possible before the call to Eno
  • maybe we could generate only a diff of the questionnaire in order to act quicker
  • we should have a versionning system for questionnaire
  • some changes in Eno are necessary if we want more detailled errors

@ORogel ORogel closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants