From 85f34bc056e921658b02550786af0813c7a1e232 Mon Sep 17 00:00:00 2001
From: Hadrien Kohl <hadrien.kohl@gmail.com>
Date: Fri, 29 Nov 2024 10:26:08 +0100
Subject: [PATCH 1/3] Highlight the problem with the ruleset

---
 .../fr/insee/vtl/SDMXVTLWorkflowTest.java     | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java b/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java
index e855df1ec..73cd9d4ba 100644
--- a/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java
+++ b/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java
@@ -30,6 +30,26 @@ public void setUp() {
         engine = mgr.getEngineByExtension("vtl");
     }
 
+    @Test
+    void testRefFromRepo() {
+        // Works partially, the transformation does not pull in the ruleset. Maybe the transformation is wrong and does not
+        // reference ruleset?
+        String url = "https://registry.sdmx.io/sdmx/v2/structure/transformationscheme/FR1/BPE_CENSUS/+/?format=sdmx-3.0&references=all";
+        ReadableDataLocation rdl = new ReadableDataLocationTmp(url);
+        SDMXVTLWorkflow sdmxVtlWorkflow = new SDMXVTLWorkflow(engine, rdl, Java8Helpers.mapOf());
+        System.out.println(sdmxVtlWorkflow.getEmptyDatasets());
+
+        System.out.println(sdmxVtlWorkflow.getTransformationsVTL());
+
+        // Invalid step definition for:CHECK_MUNICIPALITY
+        // - Caused by: fr.insee.vtl.engine.exceptions.UndefinedVariableException: undefined variable UNIQUE_MUNICIPALITY
+        engine.getBindings(ScriptContext.ENGINE_SCOPE).putAll(sdmxVtlWorkflow.getEmptyDatasets());
+        Map<String, PersistentDataset> result = sdmxVtlWorkflow.run();
+        assertThat(result).containsKeys(
+                "BPE_CENSUS_NUTS3_2021", "BPE_MUNICIPALITY", "BPE_NUTS3"
+        );
+    }
+
     @Test
     void testGetEmptyDataset() {
 

From 69839159cd183339f683d02768db094bd7ea917e Mon Sep 17 00:00:00 2001
From: Nicolas Laval <nicolas.laval@making-sense.info>
Date: Fri, 29 Nov 2024 10:53:46 +0100
Subject: [PATCH 2/3] Disable SDMX testRefFromRepo test for now

---
 vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java b/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java
index 73cd9d4ba..af3dcfdb5 100644
--- a/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java
+++ b/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java
@@ -10,6 +10,7 @@
 import io.sdmx.utils.core.io.ReadableDataLocationTmp;
 import org.apache.spark.sql.SparkSession;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import javax.script.ScriptContext;
@@ -30,6 +31,7 @@ public void setUp() {
         engine = mgr.getEngineByExtension("vtl");
     }
 
+    @Disabled
     @Test
     void testRefFromRepo() {
         // Works partially, the transformation does not pull in the ruleset. Maybe the transformation is wrong and does not

From 0fc9bb74f7a517d2449aca4ca398d52749be6e03 Mon Sep 17 00:00:00 2001
From: Nicolas Laval <nicolas.laval@making-sense.info>
Date: Fri, 29 Nov 2024 11:24:06 +0100
Subject: [PATCH 3/3] Add ruleset reference to transformation in VTL BPE sample

---
 vtl-sdmx/src/test/resources/DSD_BPE_CENSUS.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/vtl-sdmx/src/test/resources/DSD_BPE_CENSUS.xml b/vtl-sdmx/src/test/resources/DSD_BPE_CENSUS.xml
index ae2cfecd5..219abf300 100644
--- a/vtl-sdmx/src/test/resources/DSD_BPE_CENSUS.xml
+++ b/vtl-sdmx/src/test/resources/DSD_BPE_CENSUS.xml
@@ -371,6 +371,7 @@
         <str:TransformationSchemes>
           <str:TransformationScheme agencyID="FR1" id="BPE_CENSUS" version="1.0" vtlVersion="2.0">
             <com:Name xml:lang="en">Transformation Scheme for BPE - CENSUS</com:Name>
+            <str:RulesetScheme>urn:sdmx:org.sdmx.infomodel.transformation.RulesetScheme=FR1:RS1(1.0)</str:RulesetScheme>
             <str:Transformation id="STEP_1" isPersistent="false">
               <com:Name xml:lang="en">Step 1</com:Name>
               <com:Description xml:lang="en">Validation of municipality code in input file</com:Description>