Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging #6

Open
jpramil opened this issue Oct 1, 2024 · 3 comments
Open

Packaging #6

jpramil opened this issue Oct 1, 2024 · 3 comments
Assignees
@micedre @jpramil @meilame-tayebjee

Comments

@jpramil
Copy link
Contributor

jpramil commented Oct 1, 2024

TODO list to package the reimplementation :

  • allow already split train sets and test sets
@micedre
Copy link
Contributor

micedre commented Dec 4, 2024 •
edited
Loading

TODO before publishing on pypi :

  • Documentation (usage and features)
  • Add some tests (with and without categorical variables)
  • Benchmark and compare to old fasttext implementation
  • Remove useless dependencies, or mark them as optional (depending the features)

@meilame-tayebjee
Copy link
Contributor

  • documentation: good enough? (@micedre ) I can do more if necessary
  • dependencies: OK in the new PR
  • tests: what can we add?
  • benchmark: @jpramil maybe we can add sth from your previous work? not sure how should it look (a step-by-step notebook?) and if it is necessary

@micedre
Copy link
Contributor

micedre commented Dec 17, 2024 •
edited
Loading

Could we have a little paragraph on how it compares with meta implementation on an example (public) dataset ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micedre micedre

@jpramil jpramil

@meilame-tayebjee meilame-tayebjee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@micedre @jpramil @meilame-tayebjee