Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

Add dump pickle method for environments #291

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamescasbon
Copy link
Contributor

Some environments are not suited to video encoding methods. This PR allows coach to just pickle the environment render responses so that you can use them for analysis.

@jamescasbon
Copy link
Contributor Author

I can redo the documentation if you are willing to accept.

It makes the review process quite hard if you churn the docs as well.

@jamescasbon
Copy link
Contributor Author

Hi all, what do you think? Its a pretty simple change.

@gal-leibovich
Copy link
Contributor

Hi @jamescasbon, sorry for delaying with the response.

The functionality seems good to me. Which environments have you encountered that their rendering is not supported for video encoding or GIFs creation?

Also, now with #326, creating the documentation is very easy, and does not require you to have all the environments installed. #326 should be merged to master soon.

@jamescasbon
Copy link
Contributor Author

The functionality seems good to me. Which environments have you encountered that their rendering is not supported for video encoding or GIFs creation?

I have custom environments where I'd much rather get the raw data out for post processing. Maybe the raw data is recoverable from the other methods but it seemed like mp4 would be compressed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants