Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Dask interface to mkl_fft #5

Open
jakirkham opened this issue Apr 17, 2018 · 3 comments
Open

Provide Dask interface to mkl_fft #5

jakirkham opened this issue Apr 17, 2018 · 3 comments
Labels

Comments

@jakirkham
Copy link

Would be nice if a simple dask interface were provided to mkl_fft (much like the numpy one currently). In fact it could be built right on top of the _numpy_fft module by wrapping these functions using fft_wrap just as it is done in Dask except using the one's in _numpy_fft instead.

@jakirkham
Copy link
Author

Any thoughts on this, @oleksandr-pavlyk?

@oleksandr-pavlyk
Copy link
Contributor

@jakirkham I think dask interface is a great idea. I am not clear as to what exactly should be done in _numpy_fft.

Are you proposing to add _dask_fft.py to the package, which would export these fft_wrapped function if dask is found in the environment?

@jakirkham
Copy link
Author

Thanks for the follow up. Glad to hear this works.

I am not clear as to what exactly should be done in _numpy_fft.

Don’t think anything has to be done to _numpy_fft. That just works well for this purpose. Namely fft_wrap works well with FFT functions adhering to the NumPy API.

Are you proposing to add _dask_fft.py to the package, which would export these fft_wrapped function if dask is found in the environment?

Yep, exactly.

Any thoughts on how we name things in the public API? Also any thoughts on what would be adequate testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants