From 802b91c545da131b15ca913fea80c3d6e4eb323d Mon Sep 17 00:00:00 2001 From: Kevin Z Date: Sat, 13 Apr 2024 22:10:17 -0600 Subject: [PATCH 1/3] Fix GUIDELINE link in PULL_REQUEST_TEMPLATE.md Signed-off-by: Kevin Z --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f4b75762c..2e659f12e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -**PLEASE READ THE [GUIDELINES](https://github.com/SirEndii/AdvancedPeripherals/blob/1.20.1/CONTRIBUTING.md) BEFORE MAKING A CONTRIBUTION** +**PLEASE READ THE [GUIDELINES](https://github.com/SirEndii/AdvancedPeripherals/blob/dev/1.20.1/CONTRIBUTING.md) BEFORE MAKING A CONTRIBUTION** * **Please check if the PR fulfills these requirements** From cc2299ff4f664ff7e965ede7978420a2532cb9bd Mon Sep 17 00:00:00 2001 From: Kevin Z Date: Sun, 14 Apr 2024 08:42:04 -0600 Subject: [PATCH 2/3] update some outdated link in CONTRIBUTING.md --- CONTRIBUTING.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ac4eddfe5..2c883c17a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,7 +22,7 @@ Translations are managed through [crowdin], a service which allows anyone to con ## Setting up a development environment -**PLEASE READ If you want to add features or fix bugs that exist in multiple versions, please make the changes for the oldest fully supported versions, which you can find [here](https://docs.advanced-peripherals.de/#version-support). That would be 1.19.2 at the time the article was written.** +**PLEASE READ If you want to add features or fix bugs that exist in multiple versions, please make the changes for the oldest fully supported versions, which you can find [here](https://docs.advanced-peripherals.de/#version-support). That would be 1.20.1 at the time the article was written.** If you want to contribute to Advanced Peripherals, you'll need to set up a development environment. This can be a tedious process for first-time contributors, but it's worth it in the long run. This guide will walk you through the process of setting up a development environment. @@ -35,11 +35,11 @@ You can also download the [IntelliJ IDEA][idea] IDE, which is what we recommend - Download AP's source code: ``` - git clone https://github.com/SirEndii/AdvancedPeripherals + git clone https://github.com/IntelligenceModding/AdvancedPeripherals cd AdvancedPeripherals ``` - If you're using IntelliJ IDEA, you can import the project by selecting `Get from version control` and then typing - in the github repository url `https://github.com/SirEndii/AdvancedPeripherals/`. + in the github repository url `https://github.com/IntelligenceModding/AdvancedPeripherals/`. - Build AP with `./gradlew build` (or double clicking the build button in Intellij IDEA). This will be very slow the first time it runs, as it needs to download all the dependencies. - Subsequent builds will be much faster. @@ -53,7 +53,7 @@ If you're having trouble setting up a development environment, [ask the communit ### Testing We currently do not have code tests for Advanced Peripherals. -However, we currently work on adding tests to Advanced Peripherals. You can contribute to this by adding tests to the project on the [dev/tests](https://github.com/SirEndii/AdvancedPeripherals/tree/dev/tests) branch. If you want to contribute to this, please contact us on [discord][discord]. +However, we currently work on adding tests to Advanced Peripherals. You can contribute to this by adding tests to the project on the [dev/tests](https://github.com/IntelligenceModding/AdvancedPeripherals/tree/dev/tests) branch. If you want to contribute to this, please contact us on [discord][discord]. ## Writing documentation @@ -63,10 +63,10 @@ Everything you need to know is stated in the readme of the documentation reposit -[new-issue]: https://github.com/SirEndii/AdvancedPeripherals/issues/new/choose "Create a new issue" +[new-issue]: https://github.com/IntelligenceModding/AdvancedPeripherals/issues/new/choose "Create a new issue" [Adoptium]: https://adoptium.net/temurin/releases?version=17 "Download OpenJDK 17" [vsc]: https://code.visualstudio.com/ "Visual Studio Code" -[docs-repo]: https://github.com/SirEndii/Advanced-Peripherals-Documentation "Advanced Peripherals Documentation Repository" +[docs-repo]: https://github.com/IntelligenceModding/Advanced-Peripherals-Documentation "Advanced Peripherals Documentation Repository" [checkstyle]: https://checkstyle.org/ [idea]: https://www.jetbrains.com/de-de/products/compare/?product=idea&product=idea-ce "IntelliJ IDEA Community Edition" [discord]: https://discord.intelligence-modding.de/ "Join the Discord" From 5c7f5edab46075157d070618e9d2c1e2b9394e16 Mon Sep 17 00:00:00 2001 From: Kevin Z Date: Sun, 14 Apr 2024 08:42:46 -0600 Subject: [PATCH 3/3] Update CONTRIBUTING.md Ok it's 1.19.2 --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2c883c17a..eda8ee55c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,7 +22,7 @@ Translations are managed through [crowdin], a service which allows anyone to con ## Setting up a development environment -**PLEASE READ If you want to add features or fix bugs that exist in multiple versions, please make the changes for the oldest fully supported versions, which you can find [here](https://docs.advanced-peripherals.de/#version-support). That would be 1.20.1 at the time the article was written.** +**PLEASE READ If you want to add features or fix bugs that exist in multiple versions, please make the changes for the oldest fully supported versions, which you can find [here](https://docs.advanced-peripherals.de/#version-support). That would be 1.19.2 at the time the article was written.** If you want to contribute to Advanced Peripherals, you'll need to set up a development environment. This can be a tedious process for first-time contributors, but it's worth it in the long run. This guide will walk you through the process of setting up a development environment.