Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME and RS bridge refactoring #689

Open
SirEndii opened this issue Jan 15, 2025 · 0 comments
Open

ME and RS bridge refactoring #689

SirEndii opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request Priority-High refactoring Breaking changes - Refactor to a better standard
Milestone

Comments

@SirEndii
Copy link
Member

This one is actually almost done. I created the two bridges at different times, and stupid young me just ignored that both bridges provide different functions and different features which now really triggers my inner perfectionist

I already "fixed" that a year ago, using an interface which basically prescribes which storage functions these bridges should have.
So this is actually almost done, it just needs some testing

/**
* Implementation for common storage peripheral functions. Used for AE2 {@link de.srendi.advancedperipherals.common.addons.computercraft.peripheral.MeBridgePeripheral}
* and RS {@link de.srendi.advancedperipherals.common.addons.computercraft.peripheral.RsBridgePeripheral}
* <p>
* This ensures that these both bridges use the same methods. This makes it easier to support both in the same script
* In case there is a new mod which adds new ways to store and craft items, this ensures that the new peripheral
* has the same functions as the other ones
* <p>
* Implementation needs to override {@link dan200.computercraft.api.lua.LuaFunction}
*/
public interface IStorageSystemPeripheral {
MethodResult isConnected();
MethodResult isOnline();

@SirEndii SirEndii converted this from a draft issue Jan 15, 2025
@SirEndii SirEndii added enhancement New feature or request Priority-High refactoring Breaking changes - Refactor to a better standard labels Jan 15, 2025
@SirEndii SirEndii added this to the 0.8r milestone Jan 15, 2025
@SirEndii SirEndii moved this from Backlog to In progress in 0.8/1.0 Backlog Jan 18, 2025
@SirEndii SirEndii self-assigned this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority-High refactoring Breaking changes - Refactor to a better standard
Projects
Status: In progress
Development

No branches or pull requests

1 participant