Fix NullPointerException when server ticking

[zyxkad]

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

• Please check if the PR fulfills these requirements

• The commit message are well described
• Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. This is not mandatory
• All changes have fully been tested

• What kind of change does this PR introduce? (Bug fix, feature, ...)

Some mod may call ServerWorker.tick with null value, this PR ensure null value never go to the queue, and if it did somehow, the null will never be executed

• What is the current behavior? (You can also link to an open issue here)

• What is the new behavior (if this is a feature change)?

• Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
  No

• Other information:

[SquidDev]

What bug is this trying to fix? I don't see any usages of ServerWorker.add that enqueue null.

[zyxkad]

https://discord.com/channels/734726882058174486/779400553813377074/1229036290264010782

[SquidDev]

That's not very helpful!. I suspect the issue here is actually due to the non-thread-safe usage of ArrayQueue. This should either use a concurrent queue, or obtain a lock on the queue.

[zyxkad]

Ok then:
Error Log

[zyxkad]

I suspect the issue here is actually due to the non-thread-safe usage of ArrayQueue. This should either use a concurrent queue, or obtain a lock on the queue.

You are right, they are running concurrently

[19PHOBOSS98]

merge please : )

[zyxkad]

@19PHOBOSS98 can you build your own version based on this PR and test if that error never happen again?

Cause it's not really easy for me to reproduce

[19PHOBOSS98]

@19PHOBOSS98 can you build your own version based on this PR and test if that error never happen again?

Cause it's not really easy for me to reproduce

sure thing! I'll be back with what I find

[19PHOBOSS98]

it doesn't crash anymore when I tried setting the threads to 4 with all of my drones flying with VS2. Thanks again! Hope this releases soon