Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlNet support #125

Open
R4rum opened this issue Feb 18, 2023 · 11 comments · May be fixed by #139
Open

ControlNet support #125

R4rum opened this issue Feb 18, 2023 · 11 comments · May be fixed by #139
Labels
enhancement New feature or request

Comments

@R4rum
Copy link

R4rum commented Feb 18, 2023

The ControlNet extension improves the control over the composition by a lot. I would imagine it being a worthwhile addition.

Additional context
Currently the extension even throws errors when working in Krita:

Error running process: stable-diffusion-webui/extensions/sd-webui-controlnet/scripts/controlnet.py
Traceback (most recent call last):
  File "stable-diffusion-webui/modules/scripts.py", line 386, in process
    script.process(p, *script_args)
  File "stable-diffusion-webui/extensions/sd-webui-controlnet/scripts/controlnet.py", line 390, in process
    enabled, module, model, weight, image, scribble_mode, \
ValueError: not enough values to unpack (expected 13, got 0)
@Lute-4
Copy link

Lute-4 commented Feb 18, 2023

It would be very useful! :)

Here is the link to the webui extension:
https://github.com/Mikubill/sd-webui-controlnet

@Lute-4
Copy link

Lute-4 commented Feb 19, 2023

Maybe useful, "added an API layer":
Mikubill/sd-webui-controlnet#194

@ethanfel
Copy link

The ControlNet extension improves the control over the composition by a lot. I would imagine it being a worthwhile addition.

Additional context Currently the extension even throws errors when working in Krita:

Error running process: stable-diffusion-webui/extensions/sd-webui-controlnet/scripts/controlnet.py
Traceback (most recent call last):
  File "stable-diffusion-webui/modules/scripts.py", line 386, in process
    script.process(p, *script_args)
  File "stable-diffusion-webui/extensions/sd-webui-controlnet/scripts/controlnet.py", line 390, in process
    enabled, module, model, weight, image, scribble_mode, \
ValueError: not enough values to unpack (expected 13, got 0)

This is more an issue of controlnet than the plugin, seems the controlnet is interfering even when disabled.

Regarding it's support, yeah it would be amazing. I'm back to 2 A111 because of it. I've bind every folder with models so it's just the setting and the extensions, it's not a big deal. Controlnet is the best improvement since local fine tuning.

@Interpause
Copy link
Owner

Seems complex enough that I can't just guess what is going wrong, I may take a look at it if I have time.

@Lute-4
Copy link

Lute-4 commented Mar 5, 2023

This excellent free and open source photoshop plugin just had a new update with controlnet, maybe the code of this plugin can help the one here for krita :
https://www.reddit.com/r/StableDiffusion/comments/11iuqhv/major_update_automatic1111_photoshop_stable/
https://github.com/AbdullahAlfaraj/Auto-Photoshop-StableDiffusion-Plugin
AbdullahAlfaraj/Auto-Photoshop-StableDiffusion-Plugin#124

@Interpause
Copy link
Owner

I see, maybe I will look at it when my internship is over.

@JasonS09
Copy link

I'm currently working on a personal ControlNet implementation on my end. I'll inform how things turn out.

@Sugarun
Copy link

Sugarun commented Mar 30, 2023

i tried to implement controlnet to auto-sd and use it in krita but apparently i'm too stupid for that. if you could describe how you did it i would be eternally grateful.

@JasonS09
Copy link

i tried to implement controlnet to auto-sd and use it in krita but apparently i'm too stupid for that. if you could describe how you did it i would be eternally grateful.

I haven't done it yet, I'm still working on the UI but I've got some approaches in mind. If it turns great then I'll share it.

@dmarx
Copy link

dmarx commented May 2, 2023

the deforum plugin has good controlnet support plus a lot of other features (especially powerful for image-to-image animation). if getting controlnet support added is going to require onboarding another plugin, might get more bang for your buck integrating deforum. no idea if there's a difference in LOE between adding support for just controlnet vs. deforum. maybe if we reach out to the gradio team, they could come up with some more generic support between gradio applications and krita?

@Interpause
Copy link
Owner

the gradio team would probably not do that...

@Interpause Interpause added the enhancement New feature or request label May 16, 2023
@Interpause Interpause linked a pull request May 16, 2023 that will close this issue
@Interpause Interpause linked a pull request May 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants