Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - Input cost models validation #928

Open
carbolymer opened this issue Oct 7, 2024 · 2 comments
Open

[FR] - Input cost models validation #928

carbolymer opened this issue Oct 7, 2024 · 2 comments
Assignees

Comments

@carbolymer
Copy link
Contributor

carbolymer commented Oct 7, 2024

Internal/External
Internal

Area
Other

Context
When providing plutus cost models as an input to cardano-cli:

  • as a map
    • excess parameters are ignored, only existing parameters are checked.
    • If the existing parameters are missing, the parsing fails and the error is reported.
  • as a list
    • lists longer than expected are consumed up to the number of existing parameters - excess parameters are ignored.
    • If the list of cost model parameters is too short, the missing parameters are defaulted to maxBound :: Int64 and no error is reported.

Description
When an user provides a cost model containing too many or not enough parameters, cardano-cli should fail with an appropriate message.

Additional info
The original issue:

The v2 cost models included in Alonzo Genesis validation and conversion was implemented in

Warning

Needs clarification: Which cost models should we cover with this validation? V1? V2? V3?

Copy link

github-actions bot commented Nov 8, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Nov 8, 2024
@smelc smelc removed the Stale label Nov 8, 2024
Copy link

github-actions bot commented Dec 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Dec 9, 2024
@smelc smelc removed the Stale label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants