Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

∆r in RewardUpdate can be positive, which may cause issues with serialization #4771

Open
WhatisRT opened this issue Nov 21, 2024 · 0 comments

Comments

@WhatisRT
Copy link
Contributor

@bwbush looked into the reserves recently, and discovered that createRUpd can in fact create a positive value for the reserves. The easiest way to see this is to assume that the rewards pot is empty, so Δr₁ = 0, but R can still be any positive number, so Δr₂ can still be positive (which happens is stake isn't distributed perfectly). This means there are two problems:

I don't know if the second item can potentially cause any issues on mainnet, but even if, it's not going to until the reserves are pretty empty. However, it might be possible to observe some problems on testnets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant