Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CBOR instances #4895

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add CBOR instances #4895

wants to merge 1 commit into from

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Feb 18, 2025

Description

Needed FromCBOR and ToCBOR instances for:

  • FromByronTranslationContext
  • NoGenesis {AllegraEra, MaryEra, BabbageEra}
  • ConwayGenesis
  • Network
  • ActiveSlotCoeff

Closes #4893

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@jasagredo
Copy link
Contributor

In case this PR is for #4893, in consensus we actually need ToCBOR and FromCBOR instances, which I think enable deriving Enc/DecCBOR but not the other way round.

If the PR is not for that issue feel free to ignore my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add From/ToCBOR instances necessary to query the node for the LedgerConfig
2 participants