Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USERSNAP] The truncation of the action ID is really annoying, especially when it's not necessary to fit the content in the window width. For my workflow, I need to grab the transaction ID and action index separately, so copying the entire thing to the ... #2177

Closed
kickloop opened this issue Oct 17, 2024 · 4 comments

Comments

@kickloop
Copy link
Collaborator

Taken at: https://gov.tools/connected/governance_actions/7fd6429add8f2611ad8d48c0cc49101463093aec285faea402e8cfde78ea58d7#0
Fields:

  • Add a comment: The truncation of the action ID is really annoying, especially when it's not necessary to fit the content in the window width. For my workflow, I need to grab the transaction ID and action index separately, so copying the entire thing to the clipboard isn't really the best solution. Can you please have it display the entire gov action ID when there is room to do so?

SCREENSHOT
Download original image

Browser: Chrome 129 (macOS Catalina)
Screen size: 1440x900
Browser size: 1440x718
Open #148 in Usersnap

Powered by Usersnap.

@m-i-k-e
Copy link

m-i-k-e commented Oct 18, 2024

I agree, it doesn't need to be truncated here. What is the "action index"?

@m-i-k-e
Copy link

m-i-k-e commented Oct 23, 2024

I discussed this in depth with a user, possibly the same as posted this comment.

Here is a transcript:

By 'action index' I mean the index portion of the gov action ID (the bit that comes after the #)

2841a581076167a0662f1b4f1a38bcc8eff386f9ce45c33ae33b1fe8289de210#0
Like here?Why is that important? Does it mean something?

Governance actions are identified by two pieces of information - the transaction ID they were published in and the index of the governance action within the transaction (transactions can publish more than one). In most tools, these are treated as separate fields and are not parsed in the single-string format GovTool renders them as, for example, cardano-cli:
cardano-cli conway governance vote create \ --yes \ --governance-action-tx-id 2841a581076167a0662f1b4f1a38bcc8eff386f9ce45c33ae33b1fe8289de210 \ --governance-action-index 0 \ ...

So, the index is the position of the GA, and say for example there are two GAs on one transaction, they would have the same base id (in your exmaple 2841a581076167a0662f1b4f1a38bcc8eff386f9ce45c33ae33b1fe8289de210), but the first would be index 0 and the second would be index 1?

Yes

@m-i-k-e
Copy link

m-i-k-e commented Oct 23, 2024

So I've put a comment in Figma to change the main GA screen so it doesn't truncate the entire number. This should solve the problem.

@bosko-m bosko-m moved this to To do in Govtool all Nov 4, 2024
@bosko-m bosko-m moved this from To do to Backlog in Govtool all Nov 4, 2024
@bosko-m bosko-m moved this from Backlog to To do in Govtool all Nov 13, 2024
@m-i-k-e m-i-k-e assigned MSzalowski and unassigned MSzalowski Dec 3, 2024
@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Dec 27, 2024
@MSzalowski MSzalowski self-assigned this Dec 27, 2024
@MSzalowski
Copy link
Contributor

Image
Changed within one of the recent version updates.

@MSzalowski MSzalowski moved this from In progress to Done in Govtool all Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants