Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 GovTool lets me put in link description without link urls #2403

Closed
m-i-k-e opened this issue Nov 22, 2024 · 2 comments · Fixed by #2581
Closed

🐛 GovTool lets me put in link description without link urls #2403

m-i-k-e opened this issue Nov 22, 2024 · 2 comments · Fixed by #2581
Assignees
@MSzalowski
Labels
🐛 Bug Something isn't working ♟️ Delegation Pillar
Milestone
🏛 Needed for Full...

Comments

@m-i-k-e
Copy link

m-i-k-e commented Nov 22, 2024

Area

Delegation Pillar

Domain

preview.gov.tools

Which wallet were you using?

Latest Lace

Context

I was trying to register as a DREp and I put in a label for both my links and identity and no URL. The form didn't show an error.

Steps to reproduce

  1. Try to register as a DRep
  2. put in text in the description fields of both 'identity' and 'links'
  3. Don't put in any url in the url fields
  4. press "Continue" button

Actual behavior

the form submits with no errors and you go to the data download screen

Expected behavior

the form throws an error as the urls are missing.
@m-i-k-e m-i-k-e added the 🐛 Bug Something isn't working label Nov 22, 2024
@m-i-k-e
Copy link
Author

m-i-k-e commented Nov 22, 2024

Video:

https://www.loom.com/share/a73414d363084a17bdb79c912929c888?sid=f99a41f3-be17-49f8-9dc0-427ae179d1cf

@bosko-m bosko-m moved this to To do in Govtool all Nov 25, 2024
@bosko-m
Copy link
Contributor

bosko-m commented Dec 2, 2024

@MSzalowski Do we already have the way to show this error message or it needs to be designed?

@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Dec 27, 2024
MSzalowski added a commit that referenced this issue Dec 27, 2024
@MSzalowski
fix(#2403): fix DRep link and description validation
4aaac44
@MSzalowski MSzalowski linked a pull request Dec 27, 2024 that will close this issue
fix(#2403): fix DRep link and description validation #2581
Merged
5 tasks
@MSzalowski MSzalowski mentioned this issue Dec 27, 2024
Merged
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Dec 27, 2024
MSzalowski added a commit that referenced this issue Dec 27, 2024
@MSzalowski
Merge pull request #2581 from IntersectMBO/fix/2403-govtool-lets-me-p…
68b2d56 
…ut-in-link-description-without-link-urls

fix(#2403): fix DRep link and description validation
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

Labels
🐛 Bug Something isn't working ♟️ Delegation Pillar
Projects
Governance Tools Community Backlog
Status: Done
Govtool all
Status: Done
Milestone
🏛 Needed for Full governance / Mainnet
Development

Successfully merging a pull request may close this issue.

fix(#2403): fix DRep link and description validation IntersectMBO/govtool
3 participants
@m-i-k-e @MSzalowski @bosko-m