Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 CIP-119 DRep images - base64 encoded image is not supported #2633

Closed
MSzalowski opened this issue Jan 14, 2025 · 0 comments · Fixed by #2636
Closed

🐛 CIP-119 DRep images - base64 encoded image is not supported #2633

MSzalowski opened this issue Jan 14, 2025 · 0 comments · Fixed by #2636
Assignees
@MSzalowski
Labels
🐛 Bug Something isn't working ♟️ Delegation Pillar
Milestone
🏛 Needed for Full...

Comments

@MSzalowski
Copy link
Contributor

Area

Delegation Pillar

Domain

gov.tools

Which wallet were you using?

No response

Context

base64 images are not working in govtool

Steps to reproduce

  1. Register as a DRep providing base64 image in your metadata
  2. DRep list does not show image

Actual behavior

No image

Expected behavior

Image should be rendered
@MSzalowski MSzalowski added the 🐛 Bug Something isn't working label Jan 14, 2025
@MSzalowski MSzalowski self-assigned this Jan 14, 2025
@MSzalowski MSzalowski moved this to To do in Govtool all Jan 14, 2025
@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Jan 14, 2025
MSzalowski added a commit that referenced this issue Jan 14, 2025
@MSzalowski
feat(#2633): add support for base64 encoded images
2915a8d
@MSzalowski MSzalowski mentioned this issue Jan 14, 2025
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Jan 14, 2025 that will close this issue
feat(#2633): add support for base64 encoded images #2636
Merged
5 tasks
MSzalowski added a commit that referenced this issue Jan 15, 2025
@MSzalowski
Merge pull request #2636 from IntersectMBO/fix/2633-cip-119-drep-imag…
5973428 
…es-base64-encoded-image-is-not-supported

feat(#2633): add support for base64 encoded images
@github-project-automation github-project-automation bot moved this from In progress to Done in Govtool all Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

Labels
🐛 Bug Something isn't working ♟️ Delegation Pillar
Projects
Governance Tools Community Backlog
Status: Done
Govtool all
Archived in project
Milestone
🏛 Needed for Full governance / Mainnet
Development

Successfully merging a pull request may close this issue.

feat(#2633): add support for base64 encoded images IntersectMBO/govtool
2 participants
@MSzalowski @bosko-m