Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Error Handling Improvement Needed for Constitution Proposal Submission #2986

Open
kneerose opened this issue Feb 14, 2025 · 0 comments
Open

Comments

@kneerose
Copy link
Contributor

kneerose commented Feb 14, 2025

Area

Proposal Pillar

Domain

preview.gov.tools

Which wallet were you using?

No response

Context

While attempting to submit an "Update the Constitution" type proposal, the submission failed due to an invalid URL and hash for the guardrails. Additionally, a CORS issue occurred for the new constitution URL. Currently, the error messages are only displayed in the console log, making it difficult for users to identify the issue.

To improve the user experience:

  • Error messages should be displayed in a dialog box instead of just the console log.
  • Guardrails URL and hash should be pre-validated during proposal creation to ensure they match, preventing errors during submission.
  • Add validation for new constitution URL character limit

Steps to reproduce

  1. Connect with a wallet.
  2. Create a constitution-type proposal using a valid new constitution URL, e.g., https://metadata-govtool.cardanoapi.io/data/constitution.
  3. Attempt to submit the proposal as a governance action.

Actual behaviour

  • Guardrails URL and hash validation are insufficient.
  • New constitution URL limit validation error
  • Error messages are only shown in the console log.

Image

Image

Expected behaviour

  • Guardrails URL and hash should be validated during proposal creation.
  • Error messages should be displayed in a dialog box for better user visibility.
  • Reject the new constitution URL if it exceeds 128 characters during proposal creation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: To do
Development

No branches or pull requests

3 participants